Bug 552610
Summary: | Review Request: rasterview - Common Unix Printing System raster file viewer | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tim Waugh <twaugh> |
Component: | Package Review | Assignee: | Terje Røsten <terje.rosten> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, terje.rosten |
Target Milestone: | --- | Flags: | terje.rosten:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | rasterview-1.2.1-3.fc12 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-04-21 10:25:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Tim Waugh
2010-01-05 16:52:47 UTC
You might want change: %defattr(-,root,root) -> %defattr(-,root,root,-) update mime db might be needed: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database Had to apply this patch to make it build: --- /SPECS/rasterview.spec~ 2009-12-14 13:23:01.000000000 +0100 +++ /SPECS/rasterview.spec 2010-01-05 21:42:44.000000000 +0100 @@ -32,6 +32,7 @@ make BUILDROOT=%{buildroot} install rm -rf %{buildroot}%{_sysconfdir}/X11/applnk +rm -f %{buildroot}%{_datadir}/applnk/Development/rasterview.desktop desktop-file-install \ --dir %{buildroot}%{_datadir}/applications \ --add-category System \ The buildreq list list too short, at least add cups-devel, libpng-devel, libjpeg-devel and zlib-devel. That did the trick, koji built it fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=1904107 Thanks! New files: Spec URL: http://twaugh.fedorapeople.org/rasterview/rasterview.spec SRPM URL: http://twaugh.fedorapeople.org/rasterview/rasterview-1.2.1-2.fc12.src.rpm You are welcome, any input about %defattr and update mime db issues? Oh, sorry, missed those. Spec URL: http://twaugh.fedorapeople.org/rasterview/rasterview.spec SRPM URL: http://twaugh.fedorapeople.org/rasterview/rasterview-1.2.1-3.fc12.src.rpm The application/vnd.cups-raster MIME type is getting over-ridden by 'CMU raster image' which also registers for '*.ras'. Not sure if there's anything we can do about that. ok rpmlint ok spec ok naming ok dirs, perms and owns ok license: GPLv2+. All files with headers. Tag correct ok desktop file ok buildflags ok tarball 4923146954287e9e025f63b8046e02b743d0c4b9 rasterview-1.2.1.tar.gz 4923146954287e9e025f63b8046e02b743d0c4b9 rasterview-1.2.1.tar.gz.spec ok koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2123601 ! add INSTALL='install -p' to make install and download tarball with wget -N to preserve timestamps Only cosmetic timestamp issue left, fix that on import. The package rasterview is APPROVED. New Package CVS Request ======================= Package Name: rasterview Short Description: CUPS raster file viewer Owners: twaugh Branches: F-12 F-13 devel InitialCC: New Package CVS Request ======================= Package Name: rasterview Short Description: CUPS raster file viewer Owners: twaugh Branches: F-12 F-13 InitialCC: (please ignore comment #8) CVS done (by process-cvs-requests.py). Thanks! |