Bug 552831

Summary:	Merge Review: perl-Date-Manip - A Perl module containing a wide variety of date manipulation routines
Product:	[Fedora] Fedora	Reporter:	Marcela Mašláňová <mmaslano>
Component:	Package Review	Assignee:	Jaroslav Škarvada <jskarvad>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, jskarvad, notting
Target Milestone:	---	Flags:	jskarvad: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-01-13 09:23:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marcela Mašláňová 2010-01-06 09:37:18 UTC

SRPM: http://kojipkgs.fedoraproject.org/packages/perl-Date-Manip/5.54/4.fc13/src/perl-Date-Manip-5.54-4.fc13.src.rpm
Spec: http://koji.fedoraproject.org/koji/fileinfo?rpmID=1714550&filename=perl-Date-Manip.spec
Description: This is a set of routines designed to make any common date/time manipulation easy to do. Operations such as comparing two times, calculating a time a given amount of time from another, or parsing international times are all easily done.

Comment 1 Jaroslav Škarvada 2010-01-12 22:40:03 UTC

MUST items:
[NO] rpmplint is silent:

$ rpmlint ./perl-Date-Manip.spec.
./perl-Date-Manip.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

[YES] Package meets naming and packaging guidelines.
Please see note (1).
[YES] Spec file matches base package name.
[YES] License file is present, matching with spec file, Licensing Guidelines are met.
Please see note (2).
[YES] Spec file is legible and in American English.
[YES] Source match upstream.
[YES] Package builds OK.
[YES] BuildRequires is correct.
[YES] Package owns all the directories it creates.
[YES] Package has no duplicity in %files.
[YES] Permission on files are set properly.
[YES] %clean section is correct.
[YES] Spec file has consistent macro usage.
[YES] Package is code or permissible content.
[YES] %doc files don't affect runtime.
[YES] Package doesn't own files that other packages own.
[YES] Package has rm -rf RPM_BUILD_ROOT at beginning of %install.
[YES] All filenames are valid UTF-8.

Should items:
[YES] Should builds in mock.
[YES] Should have sane scriptlets.

Notes:
(1) Extra space in %description after the end of the first sentence.
(2) Can be LICENSE file included to %doc?

Comment 2 Marcela Mašláňová 2010-01-13 08:29:53 UTC

Thank you for your review, everything should be fixed in 
perl-Date-Manip-5.54-5.fc13.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1918200

Comment 3 Jaroslav Škarvada 2010-01-13 09:13:58 UTC

ACCEPT, thank you.