Bug 553847

Summary: Review Request: pki-tks - The Dogtag Token Key Service
Product: [Fedora] Fedora Reporter: Kevin Wright <kwright>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: alee, awnuk, cfu, fedora-package-review, gsterlin, jmagne, kwright, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.3.0-4.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-02-04 05:02:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 520534    

Description Kevin Wright 2010-01-09 04:27:43 UTC
first pass at getting this built in fedora

Comment 1 Kevin Wright 2010-01-13 02:16:16 UTC
Spec URL: http://people.redhat.com/kwright/pki-tks/pki-tks.spec
SRPM URL: http://people.redhat.com/kwright/pki-tks/pki-tks-1.3.0-3.fc11.src.rpm

Description: The Dogtag Token Key Service

Comment 2 Kevin Wright 2010-01-16 01:21:54 UTC
Updated spec file and src rpm:

Spec URL: http://people.redhat.com/kwright/pki-tks/pki-tks.spec
SRPM URL: http://people.redhat.com/kwright/pki-tks/pki-tks-1.3.0-4.fc11.src.rpm

Comment 3 Parag AN(पराग) 2010-01-19 08:45:14 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1931061
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
e08fa5c15a8c68bf4e2892c15f142f34f0f28158  pki-tks-1.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ Initscripts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package pki-tks-1.3.0-4.fc13.noarch =>
Provides: mimehandler(application/vnd.mozilla.xul+xml) mimehandler(application/xhtml+xml) mimehandler(text/html) mimehandler(text/mml) mimehandler(text/xml)
Requires:java >= 1:1.6.0 pki-common pki-selinux pki-silent pki-tks-ui 

APPROVED.

Comment 4 Kevin Wright 2010-01-19 15:44:41 UTC
New Package CVS Request
=======================
Package Name: pki-tks
Short Description: The Dogtag Token Key Service
Owners: kwright
Branches: F-11, F-12, EL-5
InitialCC: ausil

Comment 5 Jason Tibbitts 2010-01-19 19:22:00 UTC
CVS done (by process-cvs-requests.py).

Comment 6 Fedora Update System 2010-01-20 00:19:37 UTC
pki-tks-1.3.0-4.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pki-tks-1.3.0-4.fc11

Comment 7 Fedora Update System 2010-01-20 00:29:48 UTC
pki-tks-1.3.0-4.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/pki-tks-1.3.0-4.fc12

Comment 8 Fedora Update System 2010-01-21 00:08:01 UTC
pki-tks-1.3.0-4.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pki-tks'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0832

Comment 9 Fedora Update System 2010-01-21 00:13:43 UTC
pki-tks-1.3.0-4.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pki-tks'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0863

Comment 10 Fedora Update System 2010-02-05 23:51:26 UTC
pki-tks-1.3.0-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2010-02-06 00:03:12 UTC
pki-tks-1.3.0-4.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.