Bug 553850
| Summary: | Review Request: pki-ra - The Dogtag PKI Registration Authority | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Wright <kwright> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | alee, awnuk, cfu, fedora-package-review, gsterlin, jmagne, kwright, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | pki-ra-1.3.0-5.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-04 05:03:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 520534 | ||
|
Description
Kevin Wright
2010-01-09 04:31:25 UTC
Description: The Dogtag PKI Registration Authority Spec URL: http://people.redhat.com/kwright/pki-ra/pki-ra.spec SRPM URL: http://people.redhat.com/kwright/pki-ra/pki-ra-1.3.0-3.fc11.src.rpm Generally Perl dependencies are installed automatically. You can remove Requires for perl packages. I also see following packages not installed automatically as dependency for this pki-ra package. perl-DBD-SQLite perl-XML-NamespaceSupport When I check perl code in pki-ra source code, I see these 2 packages are not needed actually. Updated spec file and src rpm: Spec URL: http://people.redhat.com/kwright/pki-ra/pki-ra.spec SRPM URL: http://people.redhat.com/kwright/pki-ra/pki-ra-1.3.0-4.fc11.src.rpm Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1947420 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) e2b42b7b72e1fafef558eec86c33c7635f01c2c5 pki-ra-1.3.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + initscripts scriptlets present. + no duplicates in %files. + file permissions are appropriate. I don't see any need to add sub-package pki-ra-perl that will install pki-ra perl modules as install path for these modules are not standard perl module installation path. Suggestions: 1) I even don't see use of "Requires: sqlite" as its providing .so files and I see no code in pki-ra consuming it. APPROVED. New Package CVS Request ======================= Package Name: pki-ra Short Description: The Dogtag PKI Registration Authority Owners: kwright Branches: F-11, F-12, EL-5 InitialCC: ausil CVS done (by process-cvs-requests.py). pki-ra-1.3.0-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pki-ra-1.3.0-4.fc11 pki-ra-1.3.0-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pki-ra-1.3.0-4.fc12 pki-ra-1.3.0-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/pki-ra-1.3.0-4.el5 pki-ra-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-ra'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0141 pki-ra-1.3.0-4.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-ra'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1179 pki-ra-1.3.0-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-ra'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1203 pki-ra-1.3.0-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pki-ra-1.3.0-5.fc11 pki-ra-1.3.0-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pki-ra-1.3.0-5.fc12 pki-ra-1.3.0-5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/pki-ra-1.3.0-5.el5 Please follow perl related suggestions for this package also as given in https://bugzilla.redhat.com/show_bug.cgi?id=553852#c6 pki-ra-1.3.0-5.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pki-ra'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0165 pki-ra-1.3.0-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. pki-ra-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. pki-ra-1.3.0-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. pki-ra-1.3.0-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |