Bug 553898

Summary: Review Request: rubygem-jeweler - Craft the perfect RubyGem
Product: [Fedora] Fedora Reporter: Jeroen van Meeuwen <vanmeeuwen+fedora>
Component: Package ReviewAssignee: Ruben Kerkhof <ruben>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, kklic, mastahnke, mlists, mtasaka, notting, rebus, ruben
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-10-17 13:31:45 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 553902, 565549    
Bug Blocks: 201449, 553893, 555988, 632912    

Description Jeroen van Meeuwen 2010-01-09 07:11:14 EST
Spec URL: http://www.kanarip.com/custom/SPECS/rubygem-jeweler.spec
SRPM URL: http://www.kanarip.com/custom/f12/SRPMS/rubygem-jeweler-1.4.0-1.fc12.src.rpm
Description: \

Jeweler provides two things:

 * Rake tasks for managing gems and versioning of a GitHub project
 * A generator for creating kickstarting a new project

 * NOTE: %check has a lot of dependencies not yet in Fedora, so it's disabled for now
Comment 1 Ruben Kerkhof 2010-01-09 11:24:05 EST
Hi Jeroen,

There's a missing BuildRequires on rubygem-rcov.
After disabling %check, the package builds fine, but please have a look at the rpmlint output, and your umask :-)
Comment 2 Jeroen van Meeuwen 2010-01-09 11:55:21 EST
The rcov buildrequires is in there, it's just commented out as it's only need in %check which we can't execute now anyways, because of the buildrequires for %check that are not in Fedora yet.
Comment 3 Ruben Kerkhof 2010-01-31 09:46:06 EST
Ah, I didn't see that. The %check section isn't disabled in the above spec.

If you're going to use %check, don't forget to add a BR on rubygem(rake).

%{geminstdir}/%{gemname}.gemspec can be removed, it's already in %{gemdir}/specifications/%{gemname}-%{version}.gemspec
Comment 4 Mamoru TASAKA 2010-02-12 08:37:39 EST
What is the status of this bug?
Comment 5 Karel Klíč 2010-02-15 10:58:34 EST
jeweler.gemspec contains the following lines:

s.add_runtime_dependency(%q<git>, [">= 1.2.5"])
s.add_runtime_dependency(%q<rubyforge>, [">= 2.0.0"])
s.add_runtime_dependency(%q<gemcutter>, [">= 0.1.0"])

AFAIK it means rubyforge and gemcutter gems should be added to the Require section in the spec file.

Rubyforge gem also needs to be updated in Fedora, as jeweler complains about its version (when I add it to the Require section):
irb(main):003:0> require 'rubygems'
=> true
irb(main):004:0> require 'jeweler'
Gem::LoadError: RubyGem version error: rubyforge(1.0.5 not >= 2.0.0)
Comment 6 Mamoru TASAKA 2010-03-04 01:06:59 EST
Would someone update the status of this bug?

By the way I submitted rubyforge 2.0.4 / hoe 2.5.0 / fixed gemcutter 0.3.0
updates for F-12 testing / F-13 stable (for F-13 updates request will
go to stable in a day, perhaps). Currently I have no plan
to update F-11 rubyforge 1.0.5 to 2.0.4. Karel and kanarip, do you need
jeweler also for F-11?
Comment 7 Karel Klíč 2010-03-08 04:02:35 EST
Mamoru, thank you for the updates. 
I do not need jeweler in F-11.
Comment 8 Michael Stahnke 2010-08-29 21:10:36 EDT
Should this review be canceled? I would like to have jeweler in Fedora/EPEL and can package it up if this review is going nowhere.
Comment 9 Mamoru TASAKA 2010-09-09 13:45:41 EDT
Would someone update the status of this bug?

Currently the review request for rubygem-construct blocks this
review, however as far as I checked jeweler-1.4.0.gem, construct
does not seem to be needed on runtime.
Comment 10 Mamoru TASAKA 2010-09-22 13:12:24 EDT
Someone ping again?
Comment 11 Michal Ambroz 2010-09-25 14:35:45 EDT
Jeweler is used in rubygem-robots.
Comment 12 Ruben Kerkhof 2010-10-17 13:31:45 EDT
In reply to comment #8:

Sure, if you want to pick it up that would be great.