Bug 554219
| Summary: | Review Request: xorg-x11-drv-qxl - X.org driver for spice virtual GPU | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Airlie <airlied> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tomspur |
| Target Milestone: | --- | Flags: | tomspur:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-19 11:54:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dave Airlie
2010-01-11 00:00:25 UTC
Review: Good: - name ok - group ok - no static libs - no *.la - %clean there - %files ok - permissions ok - license ok (when added the headers) Needswork: - parallel make: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - Not all files have headers and there is no COPYING file. Please add them upstream. Then there will be a %doc too. - BR not ok: There is no xorg-x11-server-sdk anymore. This was replaced by xorg-x11-sersver-devel, so please use that directly. - rpmlint:$ rpmlint xorg-x11-drv-qxl-0.0.6-0.1.fc12.src.rpm x86_64/xorg-x11-drv-qxl-* - source does not match upstream: your one: 0f721feee12fe8bba7bf3c66f3dbef07 upstream: 0779efb10e30daf33187aea2ae219094 (Maybe just the timestamp, didn't check that, you could add 'timestamping = on' to ~/.wgetrc to permanently enable timestamp preserving) - please use make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' to preserve timestamps. xorg-x11-drv-qxl.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 3) xorg-x11-drv-qxl.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Spec URL: http://people.fedoraproject.org/~airlied/qxl/xorg-x11-drv-qxl.spec SRPM URL: http://people.fedoraproject.org/~airlied/qxl/xorg-x11-drv-qxl-0.0.9-0.1.fc13.src.rpm Description: Driver for QXL virtual GPU in spice QXL is a virtual GPU found in the RHEV system and spice. http://spice-space.org/ Should contains all review fixes. (In reply to comment #2) > Should contains all review fixes. - Source match upstream: 9009f4c05754b02792956a3ac745217e - preserving timestamps - rpmlint clean - BR ok - parallel make ok ###################################################### APPROVED New Package CVS Request ======================= Package Name: xorg-x11-drv-qxl Short Description: X.org driver for QXL virtual GPU Owners: airlied ssp Branches: F-12 InitialCC: xgl-maint CVS done (by process-cvs-requests.py). Build in rawhide & F-13. |