Bug 554509

Summary: [abrt] crash in gnomebaker-0.6.4-6.fc12
Product: [Fedora] Fedora Reporter: samy <samy21>
Component: gnomebakerAssignee: Tomas Smetana <tsmetana>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 12CC: tsmetana
Target Milestone: ---   
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard: abrt_hash:d4ed06eea5670868153585892b4547414f364863
Fixed In Version: 0.6.4-7.fc12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-01-15 14:40:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace none

Description samy 2010-01-11 21:02:51 UTC 
abrt 1.0.3 detected a crash.

How to reproduce
-----
1. add a few files to the data dvd
2.
3.

Attached file: backtrace
cmdline: gnomebaker
component: gnomebaker
executable: /usr/bin/gnomebaker
kernel: 2.6.31.9-174.fc12.i686
package: gnomebaker-0.6.4-6.fc12
rating: 4
reason: Process was terminated by signal 6 (Aborted)
Comment 1 samy 2010-01-11 21:02:54 UTC 
Created attachment 383094 [details]
File: backtrace
Comment 2 Tomas Smetana 2010-01-12 08:12:49 UTC 
Hello,
  there seems to be an invalid free() in one of the GTK callbacks.  I got more similar tracebacks but this one might even be useful.  There is also a bug #554514 with very similar reproducer.  I will try to reproduce the error and hopefully find the cause.  It might be that something has changed in the GTk or glib and gnomebaker just needs to be recompiled with the new libraries.
Comment 3 Tomas Smetana 2010-01-13 14:43:08 UTC 
Hello,
  I think I have a cause: gnomebaker allocates its own GtkSelectionData structures using g_new0() but then uses the stock gtk_data_selection_free() to release memory.  The GTK function however assumes the memory has been allocated as a GLib memory slice.  This appears in several places in the code and seems to lead to the crashes as the one you observed.

If I'm right then this shouldn't be difficult to patch (change g_new0 to g_slice_new0).
Comment 4 samy 2010-01-13 20:21:48 UTC 
Hi,
  thank you! When is the patch ready? Can i download from repo as package update?
Comment 5 Fedora Update System 2010-01-14 08:18:16 UTC 
gnomebaker-0.6.4-7.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/gnomebaker-0.6.4-7.fc12
Comment 6 samy 2010-01-14 17:50:40 UTC 
This is a good patch, no crash.
Comment 7 Fedora Update System 2010-01-19 19:46:50 UTC 
gnomebaker-0.6.4-7.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.