Bug 554516

Summary:	Diff results on system's View File Comparison screen are not pre-formatted.
Product:	[Community] Spacewalk	Reporter:	Jeremy Mueller <jmueller>
Component:	WebUI	Assignee:	Justin Sherrill <jsherril>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Red Hat Satellite QA List <satqe-list>
Severity:	low	Docs Contact:
Priority:	low
Version:	0.7	CC:	mmraka
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-02-16 12:56:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	543511

Description Jeremy Mueller 2010-01-11 21:25:20 UTC

Description of problem:

When going to a system's View File Comparison page (https://host.name/rhn/systems/details/configuration/ViewDiffResult.do) from a System History Event for Last Spacewalk and System Comparison, the Diff results are not displayed in a fixed font (pre-formatted).

Version-Release number of selected component (if applicable):

Spacewalk 0.7


How reproducible:

Always

Steps to Reproduce:
1. Make a local change to a Spacewalk manage configuration file.
2. Let the nightly system config comparison run.
3. Click Systems -> System Name -> Configuration
4. Under the "Last Spacewalk and System Comparison" section, click on "View Details".
5. Click on "Differences exist" beside the changed file.
  
Actual results:

The unified diff is viewed as one continuous line / paragraph.

Expected results:

The unified diff to be displayed as fixed font / pre-formated.

Additional info:

Comment 1 Justin Sherrill 2010-01-13 17:16:06 UTC

Added something similar to how kickstarts are displayed.

3c3daed9bf1bb70d9a6a9cf91f91cd922d468c5f

Thanks for the bz!

Comment 2 Jeremy Mueller 2010-01-14 17:51:50 UTC

I tried testing this change by modifying /var/lib/tomcat5/webapps/rhn/WEB-INF/pages/configuration/sdc/viewdiffresult.jsp on my Spacewalk server and restarting Spacewalk, but I'm not seeing it.  What else do I need to do to test it?

Thanks,

Jeremy

Comment 3 Justin Sherrill 2010-01-14 21:19:24 UTC

Hi Jeremy,

I think you need to apply this patch to your /etc/tomcat5/web.xml file and then just bounce tomcat.



--- web.xml     2007-06-12 16:55:38.000000000 -0400
+++ web.xml.work        2007-06-12 16:55:25.000000000 -0400
@@ -194,6 +194,10 @@
             <param-name>xpoweredBy</param-name>
             <param-value>false</param-value>
         </init-param>
+        <init-param>
+            <param-name>development</param-name>
+            <param-value>true</param-value>
+        </init-param>
         <load-on-startup>3</load-on-startup>
     </servlet>

Comment 4 Michael Mráka 2010-02-16 12:59:57 UTC

Spacewalk 0.8 has been released