Bug 555244 (perl-Throwable)

Summary:	Review Request: perl-Throwable - Role for classes that can be thrown
Product:	[Fedora] Fedora	Reporter:	Iain Arnell <iarnell>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Throwable/
Whiteboard:
Fixed In Version:	0.100090-1.fc12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-01-16 07:40:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Iain Arnell 2010-01-14 05:25:23 UTC

Spec URL: http://fedorapeople.org/~iarnell/review/perl-Throwable.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Throwable-0.100090-1.fc13.src.rpm

Description:
Throwable is a role for classes that are meant to be thrown as exceptions
to standard program flow. It is very simple and does only two things: saves
any previous value for $@ and calls die $self.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1920359

*rt-0.10

Comment 1 Parag AN(पराग) 2010-01-15 07:48:57 UTC

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1920359
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
26ea04ae48d0ac317c07bcfc0eac98e708f5df4b  Throwable-0.100090.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=11,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.56 cusr  0.05 csys =  0.66 CPU)
+ Package perl-Throwable-0.100090-1.fc12.noarch =>
Provides: perl(Throwable) = 0.100090 perl(Throwable::Error) = 0.100090
Requires: perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints)

+ Not a GUI application

APPROVED.

Comment 2 Iain Arnell 2010-01-15 08:34:44 UTC

New Package CVS Request
=======================
Package Name: perl-Throwable
Short Description: Role for classes that can be thrown
Owners: iarnell
Branches: F-11 F-12
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2010-01-15 19:59:39 UTC

CVS done.

Comment 4 Fedora Update System 2010-01-16 07:44:45 UTC

perl-Throwable-0.100090-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-Throwable-0.100090-1.fc12

Comment 5 Fedora Update System 2010-01-27 01:11:06 UTC

perl-Throwable-0.100090-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.