Bug 555647

Summary:	Publican includes commented out material in strings in POT files
Product:	[Community] Publican	Reporter:	Ruediger Landmann <rlandman+disabled>
Component:	publican	Assignee:	Jeff Fearn 🐞 <jfearn>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	1.6	CC:	jfearn, mmcallis, nb, publican-list, rlandman
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	1.4-1.fc12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-02-01 01:14:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ruediger Landmann 2010-01-15 04:30:07 UTC

Description of problem:
When a string in an XML file contains commented out material, this material is carried across to the POT file.

Version-Release number of selected component (if applicable):
12

How reproducible:
100%

Steps to Reproduce:
1. Comment out some text within a para in an XML file
2. Run publican update_pot
3. Open the corresponding POT file
  
Actual results:
The POT file contains the commented-out text

Expected results:
The POT file should not contain commented-out text

Additional info:

Comment 1 Jeff Fearn 🐞 2010-01-18 05:50:32 UTC

Added parameter to new_tree to disable retaining comments.

workaround: do not place comments in translatable tags.

Comment 2 Fedora Update System 2010-01-29 02:05:38 UTC

publican-1.4-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/publican-1.4-1.fc12

Comment 3 Fedora Update System 2010-01-29 02:06:55 UTC

publican-1.4-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/publican-1.4-1.fc11

Comment 4 Fedora Update System 2010-02-01 01:13:46 UTC

publican-1.4-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2010-02-01 01:22:06 UTC

publican-1.4-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.