Bug 555693

Summary: [LTC 6.0 FEAT] KVM network performance: vhost-net patches
Product: Red Hat Enterprise Linux 6 Reporter: IBM Bug Proxy <bugproxy>
Component: kernelAssignee: Steve Best <sbest>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: low    
Version: 6.0CC: aliguori, dyuan, jjarvis, jolsa, mgahagan, nobody+PNT0273897, rpacheco, sbest, snagar, tgraf
Target Milestone: betaKeywords: FutureFeature
Target Release: 6.0   
Hardware: other   
OS: All   
Whiteboard:
Fixed In Version: kernel-2.6.32 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-07-02 19:19:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 356741, 532696    

Description IBM Bug Proxy 2010-01-15 08:20:41 UTC
=Comment: #0=================================================
Sridhar Samudrala <sri.com> - 
+++ This bug was initially created as a clone of Bug #57507 +++

1. Feature Overview:
Feature Id:	[202045]
a. Name of Feature:	vhost-net  and  vm network performance
b. Feature Description
vhost-net patchset : add  tap and raw socket backend support to host kernel to improve network latency
 udp fragmentation offload: improve throughput of guest-host/guest-guest by enabling UFO to
send/receive large UDP packets 
 - virtio-net performance enhancement : avoid unnecessary skb allocs/frees for large packet in guest
receive path by deferring skb allocations
 IGMP Snooping - to briding code to improve multicast performnace when using a bridge to connect
multiple guests.

2. Feature Details:
Sponsor:	LTC
Architectures:
x86
x86_64

Arch Specificity: Both
Affects Kernel Modules: Yes
Delivery Mechanism: Direct from community
Category:	Xen
Request Type:	Kernel - Enhancement from Upstream
d. Upstream Acceptance:	In Progress
Sponsor Priority	1
f. Severity: High
IBM Confidential:	no
Code Contribution:	3rd party code
g. Component Version Target:	2.6.33
 qemu 0.12

3. Business Case
The network performance for  communication across VM to VM and host-VM  must be close to native
perf. to migrate applications to KVM, be competitive with industry virtualization solutions, and
support efficient workloads even as a large number of VMs supported per host.

4. Primary contact at Red Hat: 
John Jarvis
jjarvis

5. Primary contacts at Partner:
Project Management Contact:
Albert Kopp, AKOPP.com

Technical contact(s):
Vivek Kashyap, vivk.com
Sridhar Samudrala, samudrala.com

IBM Manager:
Deneen T. Dock, deneen.com
=Comment: #1=================================================
Sridhar Samudrala <sri.com> - 
vhost-net patchset : add  tap and raw socket backend support to host kernel to improve network latency

Patches are submitted for inclusion in 2.6.33.

Comment 2 John Jarvis 2010-02-04 18:57:39 UTC
So did this get accepted upstream in 2.6.33 and if so, is IBM planning to provide backports for this feature?  We are just about out of runway to do this for RHEL 6.0.

Comment 4 IBM Bug Proxy 2010-02-04 19:20:52 UTC
------- Comment From sri.com 2010-02-04 14:16 EDT-------
vhost-net patches are accepted into davem's net-next-2.6 tree and are targeted for 2.6.34.

But, based on the discussions in the IBM/RH interlock calls, it looks like these patches are already in RHEL6 kernel tree.

Comment 5 IBM Bug Proxy 2010-02-04 19:41:21 UTC
------- Comment From xma.com 2010-02-04 14:30 EDT-------
We also need to backport removing send queue patch for virtio_net. It could gain transmission performance. netperf TCP STREAM test shows 20% increase.

------- Comment From sri.com 2010-02-04 14:38 EDT-------
Shirley,
defer skb allocation patches to optimize virtio-net are tracked via another bugzilla.
Bug 58968   -  RH555698-[LTC 6.0 FEAT] KVM network performance: Defer skb allocation in virtio-net

Comment 6 John Jarvis 2010-02-04 19:47:22 UTC
But there are no patches in this BZ nor in https://bugzilla.redhat.com/show_bug.cgi?id=555698 so if they did go into RHEL 6 kernel tree, where were they submitted?

Comment 9 Steve Best 2010-02-06 18:05:04 UTC
(In reply to comment #7)
> ------- Comment From sri.com 2010-02-04 17:07 EDT-------
> vhost-net patches were submitted by Michael Tsirkin of Redhat. Here are the
> links to the patches in net-next-2.6.
> 

> 1) http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=05c2828c72c4eabf62376adfe27bd24797621f62
> 2) http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=5da779c34ccff5e1e617892b6c8bd8260fb1f04c
> 3) http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=3a4d5c94e959359ece6d6b55045c3f046677f55c
> 4) http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=17660f81243e998f36257881ac3ae61685bf91c1    

John Jarvis asked me to check to see if these 4 patches we in RHEL 6 and as of kernel-2.6.32-14.el6 patch 1, 2, 3 are in patch 4 is not in.

Comment 10 Steve Best 2010-02-09 14:26:32 UTC
(In reply to comment #9)
> (In reply to comment #7)
> > ------- Comment From sri.com 2010-02-04 17:07 EDT-------
> > vhost-net patches were submitted by Michael Tsirkin of Redhat. Here are the
> > links to the patches in net-next-2.6.
> > 
> 
> > 1) http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=05c2828c72c4eabf62376adfe27bd24797621f62
> > 2) http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=5da779c34ccff5e1e617892b6c8bd8260fb1f04c
> > 3) http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=3a4d5c94e959359ece6d6b55045c3f046677f55c
> > 4) http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=17660f81243e998f36257881ac3ae61685bf91c1    
> 
> John Jarvis asked me to check to see if these 4 patches we in RHEL 6 and as of
> kernel-2.6.32-14.el6 patch 1, 2, 3 are in patch 4 is not in.    

Patch 4 was just posted to rh-kernel mailing list by Michael Tsirkin the post is here [RHEL6 PATCH 8/8] vhost: fix TUN=m VHOST_NET=y
http://post-office.corp.redhat.com/archives/rhkernel-list/2010-February/msg00472.html
the bz for that post is 
https://bugzilla.redhat.com/show_bug.cgi?id=562837

I assume this patch will make it in RHEL6 and no additional work needs to be done for this bz.

Comment 14 Anthony Liguori 2010-03-31 16:07:38 UTC
vhost-net is already in the RHEL6 kernel

Comment 15 dyuan 2010-06-13 07:36:27 UTC
According to comment 14, change bug status to VERIFIED.

Comment 16 IBM Bug Proxy 2010-06-28 23:31:04 UTC
------- Comment From sri.com 2010-06-28 19:21 EDT-------
Marking this feature as Verified.

Comment 17 releng-rhel@redhat.com 2010-07-02 19:19:29 UTC
Red Hat Enterprise Linux Beta 2 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.

Comment 18 Red Hat Bugzilla 2023-09-14 01:19:58 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days