Bug 555941
| Summary: | Review Request: eclipse-manpage - Man page viewer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kurtakov <akurtako> |
| Component: | Package Review | Assignee: | Mat Booth <mat.booth> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mat.booth, notting |
| Target Milestone: | --- | Flags: | mat.booth:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-20 13:21:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alexander Kurtakov
2010-01-15 23:06:18 UTC
A review is forthcoming. :-) Sorry for the delay, eventful weekend... Nitpick 1: SPEC file must be in American English: There's a tiny grammatical error in the package description; there should be no apostrophe in the possessive form of "it". Nitpick 2: I know it isn't the case for this package, but I think it's good practice to check for class files and jars in the source for Java packages, as per the Java package template [1] or the bit of script from the Eclipse plug-in guidelines. [2] Nitpick 3: Please use %global instead of %defined. [3] If these lines were generated by RPMStubby, we should probably file a bug there too. If you are happy to address these three things, then I say this package is APPROVED. [1] http://fedoraproject.org/wiki/Packaging:Java#ant [2] http://fedoraproject.org/wiki/Packaging:EclipsePlugins#Pre-built_binaries [3] http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define (In reply to comment #2) > Sorry for the delay, eventful weekend... > > > Nitpick 1: > > SPEC file must be in American English: There's a tiny grammatical error in the > package description; there should be no apostrophe in the possessive form of > "it". Fixed. > > Nitpick 2: > > I know it isn't the case for this package, but I think it's good practice to > check for class files and jars in the source for Java packages, as per the Java > package template [1] or the bit of script from the Eclipse plug-in guidelines. > [2] Fixed. Though as an upstream developer I don't think this is needed. > > Nitpick 3: > > Please use %global instead of %defined. [3] If these lines were generated by > RPMStubby, we should probably file a bug there too. Fixed and rpmstubby bug opened. > > > If you are happy to address these three things, then I say this package is > APPROVED. > > > [1] http://fedoraproject.org/wiki/Packaging:Java#ant > [2] http://fedoraproject.org/wiki/Packaging:EclipsePlugins#Pre-built_binaries > [3] > http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define New sources: Spec URL: http://akurtakov.fedorapeople.org/eclipse-manpage.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-manpage-0.0.1-0.svn24060.1.fc12.src.rpm APPROVED New Package CVS Request ======================= Package Name: eclipse-manpage Short Description: Man page viewer Owners: akurtakov Branches: InitialCC: CVS done (by process-cvs-requests.py). Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=151950 Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=151950 |