Bug 555988

Some notes:

* Unneeded macros
  - %ruby_sitelib macro is used nowhere.

* Requires
  - rubygem(activerecord) seems to be needed for executing
    test program and doesn't seem to be needed on runtime
    (and also see below)

* Test program
  - As this gem contains test/ directory, please add %check
    stage and execute some test program (like rake test)
    in the stage.

Mamoru, thanks for looking at this.

> Unneeded macros
Ok, removed.

> Requires: rubygem(activerecord) doesn't seem to be needed on runtime
The very last line of the main source file gems/acts_as_tree-0.1.0/lib/acts_as_tree.rb says:
ActiveRecord::Base.class_eval { include ActsAsTree }

So the gem won't work without ActiveRecord.

> Test program
'rake test' needs rubygem(jeweler), which is not packaged and seems to have a lot of dependencies. I'll try to package it, though.

(In reply to comment #2)
> > Requires: rubygem(activerecord) doesn't seem to be needed on runtime
> The very last line of the main source file
> gems/acts_as_tree-0.1.0/lib/acts_as_tree.rb says:
> ActiveRecord::Base.class_eval { include ActsAsTree }
> 
> So the gem won't work without ActiveRecord.

- Ah, umm, then shouldn't this ruby script have
  require 'active_record' ; require 'active_record/base' or so?

> 
> > Test program
> 'rake test' needs rubygem(jeweler), which is not packaged and seems to have a
> lot of dependencies. I'll try to package it, though.
- rubygem-jewler review request is actually submitted by
  kanarip (bug 553898)
  

When modification is done, please upload new spec/srpm
with release number changed.

Spec URL: http://kklic.fedorapeople.org/rubygem-acts_as_tree.spec
SRPM URL: http://kklic.fedorapeople.org/rubygem-acts_as_tree-0.1.0-2.fc12.src.rpm

I wrote an email about the require 'active_record' to the maintainer of this gem.

* Sat Jan 30 2010 Karel Klic <kklic> - 0.1.0-2
- Removed unused macro %%ruby_sitelib
- Added %%check section
- Changed spelling in the description

Spec URL: http://kklic.fedorapeople.org/rubygem-acts_as_tree.spec
SRPM URL: http://kklic.fedorapeople.org/rubygem-acts_as_tree-0.1.1-1.fc12.src.rpm

A new version that includes the require 'active_record/base' has been released.

* Thu Feb  4 2010 Karel Klic <kklic> - 0.1.1-1
- New upstream version

Created attachment 389167 [details]
mock build log for 0.1.1-1

Well, mockbuild of 0.1.1-1 fails as attached.
Note that rubygem-jeweler-1.4.0-1.fc12.src by kanarip on
bug 553898 is used.

Currently I don't know if this is due to act_as_tree side or
jeweler side or something else.

The failure is probably caused by the jeweler gem, see
https://bugzilla.redhat.com/show_bug.cgi?id=553898#c5

(Just a note that I postpone review request until blocking bug 553898
 (review request for rubygem-jeweler) gets nearly complete)

Hi guys,

This review is apparently blocked by unnecessary dependencies. Please execute the test suite by some alternative way, without use of rake. You can find some hints here: https://fedoraproject.org/wiki/Packaging_talk:Ruby

BTW I am not sure if this version is compatible with Rails 3 which are available in F15 and above.

I do not use this package any more and it would need a rework for Rails 3.