Bug 557021
| Summary: | Review Request: rubygem-merb-gen - Application and plugin generator scripts for Merb | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthew Kent <mkent> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-merb-gen-1.0.15-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-25 07:05:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 551817 | ||
| Bug Blocks: | |||
|
Description
Matthew Kent
2010-01-20 06:27:34 UTC
Looks okay, also your test passes. One question: - About "rake spec" Currently rake_helpers.rb is missing. Perhaps this file is the below: http://github.com/wycats/merb/blob/master/rake_helpers.rb Anyway without this file, chaging Rakefile as below seems to make "rake spec" pass: -------------------------------------------------------------------- --- Rakefile.orig 1970-01-01 09:00:00.000000000 +0900 +++ Rakefile 2010-02-13 01:50:28.000000000 +0900 @@ -1,4 +1,10 @@ -require File.expand_path(File.join(File.dirname(__FILE__), "..", "rake_helpers")) +#require File.expand_path(File.join(File.dirname(__FILE__), "..", "rake_helpers")) +begin ; require "rubygem" ; rescue LoadError ; end +require "merb-core" +require "rake" +require "rake/gempackagetask" +require "spec" +require "spec/rake/spectask" ############################################################################## # Package && release -------------------------------------------------------------------- Would you consider to enable %check ? Thanks for the review! (In reply to comment #1) > Looks okay, also your test passes. > > One question: > - About "rake spec" > Currently rake_helpers.rb is missing. Perhaps this file is the below: > http://github.com/wycats/merb/blob/master/rake_helpers.rb > Yeah I think they forgot to update the gemspec before the latest release. Looks fixed now. > Anyway without this file, chaging Rakefile as below seems to > make "rake spec" pass: > -------------------------------------------------------------------- > --- Rakefile.orig 1970-01-01 09:00:00.000000000 +0900 > +++ Rakefile 2010-02-13 01:50:28.000000000 +0900 > @@ -1,4 +1,10 @@ > -require File.expand_path(File.join(File.dirname(__FILE__), "..", > "rake_helpers")) > +#require File.expand_path(File.join(File.dirname(__FILE__), "..", > "rake_helpers")) > +begin ; require "rubygem" ; rescue LoadError ; end > +require "merb-core" > +require "rake" > +require "rake/gempackagetask" > +require "spec" > +require "spec/rake/spectask" > > Looks good to me and tests okay. Thanks! Spec URL: http://magoazul.com/wip/SPECS/rubygem-merb-gen.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-merb-gen-1.0.15-2.fc13.src.rpm * Mon Feb 15 2010 Matthew Kent <mkent> - 1.0.15-2 - Patch from Mamoru Tasaka to permit enabling of %%check phase (#557021). I will recheck this later. By the way would you have some time to review my review request bug 565603 ? It is preferable that check test is executed under %_builddir
(i.e.
%check
pushd .%{geminstdir}
rake spec
) rather than %buildroot, however other things are okay.
-------------------------------------------------------------------
This package (rubygem-merb-gen) is APPROVED by mtasaka
-------------------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-merb-gen Short Description: Application and plugin generator scripts for Merb Owners: mkent Branches: F-11 F-12 InitialCC: Now F-13 is branched. Oh yes - thanks. Take two: New Package CVS Request ======================= Package Name: rubygem-merb-gen Short Description: Application and plugin generator scripts for Merb Owners: mkent Branches: F-11 F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). rubygem-merb-gen-1.0.15-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-merb-gen-1.0.15-2.fc11 rubygem-merb-gen-1.0.15-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-merb-gen-1.0.15-2.fc12 rubygem-merb-gen-1.0.15-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-merb-gen-1.0.15-2.fc13 Closing. rubygem-merb-gen-1.0.15-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. rubygem-merb-gen-1.0.15-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. rubygem-merb-gen-1.0.15-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rubygem-merb-gen New Branches: el5 el6 Owners: stahnma mkent is aware of request Git done (by process-git-requests). |