Bug 557546
| Summary: | Review Request: telepathy-sunshine - Gadu-Gadu connection manager for telepathy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julian Sikorski <belegdol> |
| Component: | Package Review | Assignee: | Patrick Dignan <dignan.patrick> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dignan.patrick, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | dignan.patrick:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | telepathy-sunshine-0.1.6-1.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-23 23:18:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Julian Sikorski
2010-01-21 19:22:10 UTC
This package has one inconsistent use of macros in the %files section. I was also unable to make the package work. Did you get a chance to resolve these issues? I fixed the macro. I was unable to reproduce the "package not working" part, though. I might try to set up a rawhide VM, but I have a 3G modem right now, so I need to find a better connection to do that. Spec URL: http://belegdol.fedorapeople.org/telepathy-sunshine/telepathy-sunshine.spec SRPM URL: http://belegdol.fedorapeople.org/telepathy-sunshine/telepathy-sunshine-0.1.5-3.20100202git.fc12.src.rpm New release, I packaged the latest git snapshot. Changes: - Updated to the git snapshot - Changed license to GPLv3+ - Added python-oauth to Requires - Use %%{name} macro in %%files Maybe you'll have more luck making this one work. I'll have another shot at setting up a rawhide VM tomorrow. I tried this one in a new F12 VM that is up-to-date, but I still didn't see an option for adding Gadu-Gadu accounts once I removed telepathy-haze. I can try it in my rawhide VM as well if you'd like. Spec URL: http://belegdol.fedorapeople.org/telepathy-sunshine/telepathy-sunshine.spec SRPM URL: http://belegdol.fedorapeople.org/telepathy-sunshine/telepathy-sunshine-0.1.5-4.20100208git.fc12.src.rpm New release: - Updated to the latest git snapshot - Added libtelepathy to Requires as a workaround This should work now. Once I prove that having -haze installed is enough, I'll drop the libtelepathy dependency. Spec URL: http://belegdol.fedorapeople.org/telepathy-sunshine/telepathy-sunshine.spec SRPM URL: http://belegdol.fedorapeople.org/telepathy-sunshine/telepathy-sunshine-0.1.6-1.fc12.src.rpm New release: - Updated to 0.1.6 - Dropped libtelepathy requirement, -haze is enough As in changelog. I installed F-12 VM, and then removed -haze and installed -sunshine. There was no gadugadu in the list. But, installing -haze was enough to make the protocol appear in the list. Avatars work, which means that the right CM is used, and the protocol stays there even after -haze is gone. No need to drag in libtelepathy. I have tested this and it now works, spec file meets requirements. Review passed :) New Package CVS Request ======================= Package Name: telepathy-sunshine Short Description: Gadu-Gadu connection manager for telepathy Owners: belegdol Branches: F-13 F-12 F-11 InitialCC: This review is really light on substance, and it looks to me as if this is the first review done by this reviewer. I'm going to hold off on processing CVS for this ticket until either we get a more substantive review or one of the CVS admins has a chance to double check everything. I went ahead and looked this over more closely. This is a pretty simple package and I don't see anything outstanding on it. It is very helpful to use a checklist and slow each of the items so people looking at the review can confirm that things were checked. CVS done (by process-cvs-requests.py). telepathy-sunshine-0.1.6-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/telepathy-sunshine-0.1.6-1.fc13 telepathy-sunshine-0.1.6-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/telepathy-sunshine-0.1.6-1.fc12 telepathy-sunshine-0.1.6-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/telepathy-sunshine-0.1.6-1.fc11 telepathy-sunshine-0.1.6-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update telepathy-sunshine'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/telepathy-sunshine-0.1.6-1.fc11 telepathy-sunshine-0.1.6-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update telepathy-sunshine'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/telepathy-sunshine-0.1.6-1.fc13 telepathy-sunshine-0.1.6-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update telepathy-sunshine'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/telepathy-sunshine-0.1.6-1.fc12 telepathy-sunshine-0.1.6-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. telepathy-sunshine-0.1.6-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. telepathy-sunshine-0.1.6-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |