Bug 557917
Summary: | Review Request: gnome-activity-journal - GUI to browse and search your Zeitgeist activities | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mads Villadsen <maxx> |
Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, mclasen, michael.monreal, notting |
Target Milestone: | --- | Flags: | mclasen:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | gnome-activity-journal-0.3.3-1.fc12 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-03-23 20:50:29 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mads Villadsen
2010-01-22 19:42:56 UTC
The description mentions "full-text search through Tracker" but as we don't have tracker 0.7.x, I don't think your rpm will actually provide any tracker functionality. Would be nice to have the new tracker anyway because it is said to work much better than 0.6.x and it had 18 releases in the past 4 month :) You are of course correct. The Tracker functionality is only enabled at runtime if the new Tracker is installed. I will remove that part from the description. And I would like the new Tracker in Fedora as well. Hopefully it will be packaged up soon enough. package builds ok with rpmbuild --rebuild, but fails in mock with Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.kOjG7v + umask 022 + cd /builddir/build/BUILD + cd gnome-activity-journal-0.3.2 + LANG=C + export LANG + unset DISPLAY + /usr/bin/python setup.py build running build running build_i18n intltool-update -p -g gnome-activity-journal unable to execute intltool-update: Permission denied error: command 'intltool-update' failed with exit status 1 rpmlint says: $ rpmlint ~/rpmbuild/RPMS/noarch/gnome-activity-journal-0.3.2-1.fc13.noarch.rpm gnome-activity-journal.noarch: W: dangling-symlink /usr/share/gnome-activity-journal/data/icons /usr/share/icons gnome-activity-journal.noarch: W: dangling-symlink /usr/share/pixmaps/gnome-activity-journal.svg /usr/share/gnome-activity-journal/data/icons/hicolor/scalable/apps/gnome-activity-journal.svg 1 packages and 0 specfiles checked; 0 errors, 2 warnings. In fact, those links are dangling, and the idea to link /usr/share/gnome-activity-journal/data/icons -> /usr/share/icons looks _very_ dubious to me. Some preliminary comments about the spec: # sitelib for noarch packages, sitearch for others (remove the unneeded one) Since you already removed the unneeded one, the comment should probably go Summary: GUI to browse and search your Zeitgeist activities I really hate the term 'GUI'. Can we go with 'Tool' or something like that ? Group: Development/Languages Not important at all, but the group seems wrong Source1: %{name}.desktop This should really go upstream, since it needs translations BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Not a big deal, but not really needed anymore nowadays, rpmbuild can figure it out on its own. %{_datadir}/icons/hicolor/*/* Since you are installing icons, you need to do the icon cache dance in %post, %postun, %posttrans, etc... checklist: package name: ok spec file name: ok packaging guidelines: see above for my overall spec file comments license: ok license field: ok license file: none in the tarball, might want to talk upstream into shipping it spec file language: ok readability: ok upstream sources: ok, but there's a newer release buildable: see above, doesn't build in mock ExcludeArch: none, ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: no, ok directory ownership: ok duplicate files: ok file permissions: ok %clean: ok macro use: ok content: permissible large docs: ok %doc content: ok headers: ok static libs: ok pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok directory ownership: ok %install: ok utf8 filenames: ok I have made a new version of the spec file and updated to the latest version of gnome-activity-journal. Spec URL: http://krakoa.dk/fedora/gnome-activity-journal.spec SRPM URL: http://krakoa.dk/fedora/gnome-activity-journal-0.3.3-1.fc12.src.rpm I also made a scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2015931 I have addressed the things you mentioned with the exception of the buildroot as removing that gave an rpmlint warning. I have made a more comprehensive patch to the installation of gnome-activity-journal (the get rid of the symlinks among other things) and I have sent it to their mailing list for comments. Thanks, looks much better now. Builds fine in mock, rpmlint says: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/gnome-activity-journal-0.3.3-1.fc14.noarch.rpm gnome-activity-journal.noarch: W: non-conffile-in-etc /etc/gconf/schemas/gnome-activity-journal.schemas 1 packages and 0 specfiles checked; 0 errors, 1 warnings. I personally find %{__python} and %{__install} silly, but that doesn't prevent me from moving this to APPROVED. Oh, I forgot one thing I wanted to point out: Please update the icon cache handling to the current recommendation: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache New Package CVS Request ======================= Package Name: gnome-activity-journal Short Description: Browse and search your Zeitgeist activities Owners: maxx Branches: F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). Mads, did you want to build this ? Yes. Sorry, I've just been really busy with other things. I'll get it done this week. gnome-activity-journal-0.3.3-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/gnome-activity-journal-0.3.3-1.fc13 gnome-activity-journal-0.3.3-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/gnome-activity-journal-0.3.3-1.fc12 Built for F-12, F-13, and devel. Closing. gnome-activity-journal-0.3.3-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. gnome-activity-journal-0.3.3-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |