Bug 558099
Summary: | Enhancement request: Log more information about the search result being a paged one | ||||||
---|---|---|---|---|---|---|---|
Product: | [Retired] 389 | Reporter: | Andrey Ivanov <andrey.ivanov> | ||||
Component: | Database - Indexes/Searches | Assignee: | Noriko Hosoi <nhosoi> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Viktor Ashirov <vashirov> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | low | ||||||
Version: | 1.2.1 | CC: | amsharma, jgalipea, rmeggins | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2015-12-07 17:15:45 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 639035 | ||||||
Attachments: |
|
Description
Andrey Ivanov
2010-01-23 17:48:19 UTC
Created attachment 447285 [details]
git patch file (master)
Description: searched entry count is logged in the access log as
(nentries=<num>). When RFC 2696 page results control is passed,
the nentries logs the page size instead of the total searched
count. andrey.ivanov proposed to log the control
info as follows:
[..] conn=# op=#RESULT err=0 tag=101 nentries=# etime=0 notes=P
This patch implemented the spec.
Also, there was a bug regarding unindexed note "notes=U" when
the paged results control is received. Only the first page logs
it, but not the rest. The bug was fixed.
Reviewed by Rich (Thanks !!!) Pushed to master. $ git merge work Updating 20d1e7c..529b056 Fast-forward ldap/servers/slapd/back-ldbm/filterindex.c | 6 ++++++ ldap/servers/slapd/back-ldbm/ldbm_search.c | 1 + ldap/servers/slapd/back-ldbm/vlv.c | 5 +++-- ldap/servers/slapd/opshared.c | 5 +++++ ldap/servers/slapd/pagedresults.c | 25 +++++++++++++++++++++++++ ldap/servers/slapd/proto-slap.h | 2 ++ ldap/servers/slapd/result.c | 3 ++- ldap/servers/slapd/slap.h | 4 ++++ ldap/servers/slapd/slapi-plugin.h | 1 + 9 files changed, 49 insertions(+), 3 deletions(-) $ git push Counting objects: 29, done. Delta compression using up to 4 threads. Compressing objects: 100% (15/15), done. Writing objects: 100% (15/15), 2.12 KiB, done. Total 15 (delta 13), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 20d1e7c..529b056 master -> master Simple Ldapsearch access logs =================================== [root@testvm ~]# tail -f /var/log/dirsrv/slapd-testvm1/access [20/Jul/2011:16:27:59 +051800] conn=13 op=46 SRCH base="ou=Accounting,dc=example,dc=com" scope=1 filter="(|(&(numSubordinates=*)(numSubordinates>=1)(|(objectClass=*)(objectClass=ldapsubentry)))(objectClass=organization)(objectClass=organizationalUnit)(objectClass=netscapeServer)(objectClass=netscapeResource)(objectClass=domain))" attrs="distinguishedName" [20/Jul/2011:16:27:59 +051800] conn=13 op=46 RESULT err=0 tag=101 nentries=0 etime=0 notes=U [20/Jul/2011:16:27:59 +051800] conn=13 op=47 SRCH base="ou=Product Development,dc=example,dc=com" scope=1 filter="(|(&(numSubordinates=*)(numSubordinates>=1)(|(objectClass=*)(objectClass=ldapsubentry)))(objectClass=organization)(objectClass=organizationalUnit)(objectClass=netscapeServer)(objectClass=netscapeResource)(objectClass=domain))" attrs="distinguishedName" [20/Jul/2011:16:27:59 +051800] conn=13 op=47 RESULT err=0 tag=101 nentries=0 etime=0 notes=U [20/Jul/2011:16:27:59 +051800] conn=13 op=48 SRCH base="ou=Product Testing,dc=example,dc=com" scope=1 filter="(|(&(numSubordinates=*)(numSubordinates>=1)(|(objectClass=*)(objectClass=ldapsubentry)))(objectClass=organization)(objectClass=organizationalUnit)(objectClass=netscapeServer)(objectClass=netscapeResource)(objectClass=domain))" attrs="distinguishedName" [20/Jul/2011:16:27:59 +051800] conn=13 op=48 RESULT err=0 tag=101 nentries=0 etime=0 notes=U [20/Jul/2011:16:27:59 +051800] conn=13 op=49 SRCH base="ou=Human Resources,dc=example,dc=com" scope=1 filter="(|(&(numSubordinates=*)(numSubordinates>=1)(|(objectClass=*)(objectClass=ldapsubentry)))(objectClass=organization)(objectClass=organizationalUnit)(objectClass=netscapeServer)(objectClass=netscapeResource)(objectClass=domain))" attrs="distinguishedName" [20/Jul/2011:16:27:59 +051800] conn=13 op=49 RESULT err=0 tag=101 nentries=0 etime=0 notes=U [20/Jul/2011:16:27:59 +051800] conn=13 op=50 SRCH base="ou=Payroll,dc=example,dc=com" scope=1 filter="(|(&(numSubordinates=*)(numSubordinates>=1)(|(objectClass=*)(objectClass=ldapsubentry)))(objectClass=organization)(objectClass=organizationalUnit)(objectClass=netscapeServer)(objectClass=netscapeResource)(objectClass=domain))" attrs="distinguishedName" [20/Jul/2011:16:27:59 +051800] conn=13 op=50 RESULT err=0 tag=101 nentries=0 etime=0 notes=U Simple Paged Search - Access Logs =================================== [root@testvm ~]# tail -f /var/log/dirsrv/slapd-testvm1/access [20/Jul/2011:16:52:16 +051800] conn=16 op=26 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:52:16 +051800] conn=16 op=26 RESULT err=0 tag=101 nentries=33 etime=0 notes=U,P [20/Jul/2011:16:52:16 +051800] conn=16 op=27 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:52:16 +051800] conn=16 op=27 RESULT err=0 tag=101 nentries=33 etime=0 notes=U,P [20/Jul/2011:16:52:17 +051800] conn=16 op=28 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:52:17 +051800] conn=16 op=28 RESULT err=0 tag=101 nentries=33 etime=0 notes=U,P [20/Jul/2011:16:52:17 +051800] conn=16 op=29 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:52:17 +051800] conn=16 op=29 RESULT err=0 tag=101 nentries=33 etime=0 notes=U,P [20/Jul/2011:16:52:17 +051800] conn=16 op=30 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:52:17 +051800] conn=16 op=30 RESULT err=0 tag=101 nentries=33 etime=0 notes=U,P [20/Jul/2011:16:52:58 +051800] conn=16 op=31 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:52:58 +051800] conn=16 op=31 RESULT err=0 tag=101 nentries=35 etime=0 notes=U,P [20/Jul/2011:16:52:59 +051800] conn=16 op=32 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:52:59 +051800] conn=16 op=32 RESULT err=0 tag=101 nentries=54 etime=0 notes=U,P [20/Jul/2011:16:53:00 +051800] conn=16 op=33 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:53:00 +051800] conn=16 op=33 RESULT err=0 tag=101 nentries=435 etime=0 notes=U,P [20/Jul/2011:16:53:01 +051800] conn=16 op=34 SRCH base="dc=example,dc=com" scope=2 filter="(objectClass=*)" attrs="cn" [20/Jul/2011:16:53:01 +051800] conn=16 op=34 RESULT err=0 tag=101 nentries=345 etime=0 notes=U,P notes=U,P - In Simple Page Search. Hence VERIFIED. |