Bug 558849

Summary: Review Request: Jep - Java Embedded Python
Product: [Fedora] Fedora Reporter: John Matthews <jmatthew>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: akurtako, dgao, fedora-package-review, guido.grazioli, notting, supercyper1
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-12-17 10:27:07 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description John Matthews 2010-01-26 10:09:49 EST
Spec URL: http://jmatthews.fedorapeople.org/jep/jep.spec
SRPM URL: http://jmatthews.fedorapeople.org/jep/jep-2.4-1.fc12.src.rpm
Jep embeds CPython in Java. It is safe to use in a heavily threaded environment,
it is quite fast and its stability is a main feature and goal.
Comment 1 Guido Grazioli 2010-04-07 14:05:33 EDT
Hi i'd like to take up the review; some preliminar notes:

* project name seems to be jepp (while Jep is the main class)
* use %global instead of %define
* pls fix indentation
* group for -javadoc is "Documentation"
* -javadoc pkg require jpackage-tools too
* if you put DSO in %{_libdir}/%{name}, shouldnt you add that dir to ld.so.cond.d?
* man page: use jep.1.*
* use install -p to preserve timestamps
Comment 2 Chen Lei 2010-05-05 05:08:47 EDT
Some minor problems:
1.Jni files are dlopend by jar files, so /sbin/ldconfig in %post and %postun is useless.
2.BuildRequires:  gcc is not needed.
Use BuildRequires: java-devel >= 1:1.6.0 and Requires:  java >= >= 1:1.6.0 instead of 1.5.0
mkdir -p $RPM_BUILD_ROOT is not needed.
examples should be installed into %{_docdir}
install -d -m 755 ${RPM_BUILD_ROOT}%{_docdir}/%{name}-%{version}/examples
cp *.py ${RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/examples
Comment 3 Alexander Kurtakov 2010-08-31 01:54:30 EDT
John, Are you still interested in getting this package into Fedora?
Comment 4 John Matthews 2010-08-31 13:02:03 EDT
Hello Alex,

Yes I would like to see this package get into Fedora.  

I will upload an updated srpm for review this week.
Comment 5 Alexander Kurtakov 2010-10-13 15:00:39 EDT
Comment 6 John Matthews 2010-10-13 16:18:35 EDT
Hi Alex,

I still would like to see this get into Fedora, but I won't have time to work on this till mid December.  

If someone else is interested in picking this up, go for it.  Otherwise I will revisit this, update to latest Jep and fix the noted packaging errors when my schedule permits.