Bug 558849

Summary:	Review Request: Jep - Java Embedded Python
Product:	[Fedora] Fedora	Reporter:	John Matthews <jmatthew>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	akurtako, dgao, fedora-package-review, guido.grazioli, notting, supercyper1
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-12-17 15:27:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description John Matthews 2010-01-26 15:09:49 UTC

Spec URL: http://jmatthews.fedorapeople.org/jep/jep.spec
SRPM URL: http://jmatthews.fedorapeople.org/jep/jep-2.4-1.fc12.src.rpm
Description: 
Jep embeds CPython in Java. It is safe to use in a heavily threaded environment,
it is quite fast and its stability is a main feature and goal.

Comment 1 Guido Grazioli 2010-04-07 18:05:33 UTC

Hi i'd like to take up the review; some preliminar notes:

* project name seems to be jepp (while Jep is the main class)
* use %global instead of %define
* pls fix indentation
* group for -javadoc is "Documentation"
* -javadoc pkg require jpackage-tools too
* if you put DSO in %{_libdir}/%{name}, shouldnt you add that dir to ld.so.cond.d?
* man page: use jep.1.*
* use install -p to preserve timestamps

Comment 2 Chen Lei 2010-05-05 09:08:47 UTC

Some minor problems:
1.Jni files are dlopend by jar files, so /sbin/ldconfig in %post and %postun is useless.
2.BuildRequires:  gcc is not needed.
3.
Use BuildRequires: java-devel >= 1:1.6.0 and Requires:  java >= >= 1:1.6.0 instead of 1.5.0
4.
mkdir -p $RPM_BUILD_ROOT is not needed.
5.
examples should be installed into %{_docdir}
install -d -m 755 ${RPM_BUILD_ROOT}%{_docdir}/%{name}-%{version}/examples
cp *.py ${RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/examples

Comment 3 Alexander Kurtakov 2010-08-31 05:54:30 UTC

John, Are you still interested in getting this package into Fedora?

Comment 4 John Matthews 2010-08-31 17:02:03 UTC

Hello Alex,

Yes I would like to see this package get into Fedora.  

I will upload an updated srpm for review this week.

Comment 5 Alexander Kurtakov 2010-10-13 19:00:39 UTC

Ping?

Comment 6 John Matthews 2010-10-13 20:18:35 UTC

Hi Alex,

I still would like to see this get into Fedora, but I won't have time to work on this till mid December.  

If someone else is interested in picking this up, go for it.  Otherwise I will revisit this, update to latest Jep and fix the noted packaging errors when my schedule permits.