Bug 559653 (perl-Class-Generate)
| Summary: | Review Request: perl-Class-Generate - Generate Perl class hierarchies | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pedro Padron <ppadron> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, j, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-29 16:49:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 559686 | ||
|
Description
Pedro Padron
2010-01-28 17:01:46 UTC
In case it helps, here's the link to a Koji scratch build for dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=1957117 Changelog for new release: - Removed "Provides:" filter in prep section - Added cpan_name macro Spec URL: http://ppadron.blog.br/rpm/specs/perl-Class-Generate.spec SRPM URL: http://ppadron.blog.br/rpm/srpms/perl-Class-Generate-1.10-2.fc12.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1970313 REVIEW :
+ rpmlint is ok
perl-Class-Generate.src: I: checking
perl-Class-Generate.noarch: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package is named according to the Package Naming Guidelines .
+ spec file name
+ The package must meet the Packaging Guidelines and Perl Guidelines
+ license ok and match upstream (from README ... like perl)
+ spec file is legible
+ sources match upstream
0fcf144585a414d20c99ce9a3491fd05 Class-Generate-1.10.tar.gz
+ source URL ok
+ build on F12 x86_64
+ build on koji (F12 ref in previous post)
+ build on mock (fedora-rawhide-x86_64)
+ BuildRequires ok
+ no locale
+ no shared library
+ no system library
+ own all directories that it creates
+ not list a file more than once in the spec
+ Permissions on files are set properly.
+ %clean ok
+ consistently use macro
+ contain code
+ small doc, no sub package
+ doc not required to run
+ no -devel
+ no -static
+ no .pc
+ no .la
+ not own files or directories already owned by other packages
+ %install start with rm -rf $RPM_BUILD_ROOT
+ all files are UTF-8
+ %check ok
+ final requires
perl >= 0:5.008
perl(:MODULE_COMPAT_5.10.0)
perl(Carp)
perl(Symbol)
perl(strict)
perl(vars)
perl(warnings::register)
+ final provides
perl(Class::Generate) = 1.10
perl(Class::Generate::Array)
perl(Class::Generate::Array_Class)
perl(Class::Generate::Array_Member)
perl(Class::Generate::Class)
perl(Class::Generate::Class_Holder)
perl(Class::Generate::Class_Method)
perl(Class::Generate::Code_Checker)
perl(Class::Generate::Constructor)
perl(Class::Generate::Hash)
perl(Class::Generate::Hash_Class)
perl(Class::Generate::Hash_Member)
perl(Class::Generate::Key_Value)
perl(Class::Generate::List_Member)
perl(Class::Generate::Member)
perl(Class::Generate::Member_Names)
perl(Class::Generate::Method)
perl(Class::Generate::Mix)
perl(Class::Generate::Own)
perl(Class::Generate::Param_Style)
perl(Class::Generate::Positional)
perl(Class::Generate::Scalar_Member)
perl(Class::Generate::Support)
perl-Class-Generate = 1.10-2.fc8
You just need to improve you %file.
Using %{perl_vendorlib}/* works but is really too "large".
Must be more explicit (this will allow you to detect change in a future version and avoid some possible issues)
Use, for example
%{perl_vendorlib}/Class
%{_mandir}/man3/Class*
After something like 2.3 years with no response, perhaps it is time to close this review ticket. Another two weeks have gone by; I'll just close this. |