Bug 560172
Summary: | Review Request: jvyamlb - YAML processor for JRuby | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Victor G. Vasilyev <victor.vasilyev> |
Component: | Package Review | Assignee: | Mo Morsi <mmorsi> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, mmorsi, notting |
Target Milestone: | --- | Flags: | mmorsi:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-02-11 20:27:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 560169, 560170 | ||
Bug Blocks: | 541638 |
Description
Victor G. Vasilyev
2010-01-30 02:34:00 UTC
Looks good for most part, builds find in mock and passes most review guidelines. A couple of specifics though: The following line doesn't work as intended: find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \; You can replace it w/ this: find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \; As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". Also why did you remove the previous entries from the changelog http://cvs.fedoraproject.org/viewvc/rpms/jvyamlb/F-11/jvyamlb.spec?view=markup Also I didn't try, but if it works w/ gcj (java-devel >= 1.5) adding gcj support to the spec is relatively easy: http://fedoraproject.org/wiki/Packaging/GCJGuidelines (In reply to comment #1) > > The following line doesn't work as intended: > find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \; > > You can replace it w/ this: > find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \; > fixed according to the Specfile Template for ant https://fedoraproject.org/wiki/Packaging:Java#ant_2 > > As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". > fixed > Also why did you remove the previous entries from the changelog > http://cvs.fedoraproject.org/viewvc/rpms/jvyamlb/F-11/jvyamlb.spec?view=markup > No, changelog in the release 0.2.5-3 contains full history. > Also I didn't try, but if it works w/ gcj (java-devel >= 1.5) adding gcj > support to the spec is relatively easy: > http://fedoraproject.org/wiki/Packaging/GCJGuidelines Releases of the package was never containing gcj bits. We shouldn't add stuff of the deprecated technology into this package. Clarification is here: https://bugzilla.redhat.com/show_bug.cgi?id=560170#c5 The release 4 is prepared for review: Spec URL: http://victorv.fedorapeople.org/files/jvyamlb.spec SRPM URL: http://victorv.fedorapeople.org/files/jvyamlb-0.2.5-4.fc13.noarch.rpm I think you mistakingly uploaded the built rpm instead of the srpm for the latest release. I'll continue w/ the review once the SRPM is uploaded. Sorry for my fault. The release 4 is prepared for review: Spec URL: http://victorv.fedorapeople.org/files/jvyamlb.spec SRPM URL: http://victorv.fedorapeople.org/files/jvyamlb-0.2.5-4.fc13.src.rpm (In reply to comment #4) > Sorry for my fault. > > The release 4 is prepared for review: > Spec URL: http://victorv.fedorapeople.org/files/jvyamlb.spec > SRPM URL: http://victorv.fedorapeople.org/files/jvyamlb-0.2.5-4.fc13.src.rpm Everything looks good. Package is fully compliant w/ guidelines and builds fine in mock when jcodings, bytelist dependencies are installed. APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. Package Change Request ====================== Package Name: jvyamlb New Branches: Owners: victorv Updated Description: YAML processor for JRuby The package https://admin.fedoraproject.org/pkgdb/packages/name/jvyamlb exists, but has been orphaned and deprecated. CVS done. cvs import done. https://fedorahosted.org/rel-eng/ticket/3378 |