Bug 560322
| Summary: | Review Request: urg - Library to access Hokuyo URG laser range finders | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tim Niemueller <tim> |
| Component: | Package Review | Assignee: | Michael Schwendt <bugs.michael> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bugs.michael, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bugs.michael:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-31 23:04:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tim Niemueller
2010-01-31 00:06:01 UTC
* Hardcoded /usr/lib in -config scripts in x86_64 package. * /usr/include/urg/findFiles.h depends on boost-devel, but this header is optional (currently) and hence the dependency on boost-devel is optional. So, this acceptable. * Only the README mentions the LGPL licensing with a single word. Less than ideal (as preferably, the source files also refer to the licensing), but acceptable. $ rpmlint urg-*.x86_64.rpm urg.x86_64: W: spelling-error Summary(en_US) Hokuyo -> Hokum, Hokusai, Hokey urg.x86_64: W: name-repeated-in-summary C URG urg.x86_64: W: spelling-error %description -l en_US Hokuyo -> Hokum, Hokusai, Hokey urg-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 4 warnings. * src.rpm crashes rpmlint from updates-testing ;) * "spectool -g urg-0.8.7-1.fc12.src/urg.spec" only retrieves a HTML page, not the tarball. * Please point out the compiler warnings to upstream. Especially the format string warnings. (In reply to comment #1) > * Hardcoded /usr/lib in -config scripts in x86_64 package. Extended norpath patch to remove those. But actually they provided /usr/lib/(c_)?urg. A patch I submitted has been recently applied to rename libraries and remove this extra sub-dir of /usr/lib, this is a remnant. > * /usr/include/urg/findFiles.h depends on boost-devel, but this header is > optional (currently) and hence the dependency on boost-devel is optional. So, > this acceptable. Added boost-devel for devel sub-package to be on the safe side. > * Only the README mentions the LGPL licensing with a single word. Less than > ideal (as preferably, the source files also refer to the licensing), but > acceptable. Will pass this request to upstream. > $ rpmlint urg-*.x86_64.rpm > urg.x86_64: W: spelling-error Summary(en_US) Hokuyo -> Hokum, Hokusai, Hokey > urg.x86_64: W: name-repeated-in-summary C URG > urg.x86_64: W: spelling-error %description -l en_US Hokuyo -> Hokum, Hokusai, > Hokey > urg-devel.x86_64: W: no-documentation > 3 packages and 0 specfiles checked; 0 errors, 4 warnings. All warnings are "ok". The spelling errors are none (company is indeed named Hokuyo), name repeated in summary intended as explained in original pos, no documentation for devel package available in tar ball. > * src.rpm crashes rpmlint from updates-testing ;) Nothing I can do about it :-) > * "spectool -g urg-0.8.7-1.fc12.src/urg.spec" only retrieves a HTML page, not > the tarball. Fixed, URL to actual file given now, spectool downloads proper file. > * Please point out the compiler warnings to upstream. Especially the format > string warnings. Will do. Spec file updated at previous place, new SRPM is at http://fedorapeople.org/~timn/robotics/urg-0.8.7-2.fc12.src.rpm. That did it. APPROVED New Package CVS Request ======================= Package Name: urg Short Description: Library to access Hokuyo URG laser range finders Owners: timn Branches: F-11 F-12 EL-5 Thank you for the quick and thorough review, Michael! CVS done (by process-cvs-requests.py). urg-0.8.7-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/urg-0.8.7-2.fc11 urg-0.8.7-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/urg-0.8.7-2.fc12 urg-0.8.7-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/urg-0.8.7-2.el5 urg-0.8.7-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. urg-0.8.7-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. urg-0.8.7-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |