Bug 560894
Summary: | Review Request: perl-Pod-Coverage-TrustPod - Allow a module's pod to contain Pod::Coverage hints | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, notting, paul |
Target Milestone: | --- | Flags: | cweyl:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/Pod-Coverage-TrustPod/ | ||
Whiteboard: | |||
Fixed In Version: | perl-Pod-Coverage-TrustPod-0.092830-4.el4 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-03-02 01:03:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 555248 | ||
Bug Blocks: |
Description
Iain Arnell
2010-02-02 05:40:26 UTC
You need to add: Requires: perl(Pod::Coverage::CountParents) (there's a "use base" clause pulling this in) Gah! Well spotted. Spec URL: http://fedorapeople.org/~iarnell/review/perl-Pod-Coverage-TrustPod.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Pod-Coverage-TrustPod-0.092830-2.fc13.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1961074 Hmm, I'm seeing a 404 error on the -2 srpm and the spec is still at -1. Sorry 'bout that - new spec and srpm are now definitely uploaded. Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1984102 These aren't blockers, but: Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given the recent fun along those lines :) Think about including %{?perl_default_filter} by default, even if just pro forma. It won't hurt anything and might save some pain down the line. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1984102 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 547ec7392d1082beabfd818cb143f247ee1c7954 Pod-Coverage-TrustPod-0.092830.tar.gz 547ec7392d1082beabfd818cb143f247ee1c7954 Pod-Coverage-TrustPod-0.092830.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Pod-Coverage-TrustPod-0.092830-2.fc13.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Pod-Coverage-TrustPod-0.092830-2.fc13.noarch.rpm perl(Pod::Coverage::TrustPod) = 0.092830 perl-Pod-Coverage-TrustPod = 0.092830-2.fc13 ====> requires for perl-Pod-Coverage-TrustPod-0.092830-2.fc13.noarch.rpm perl(base) perl(:MODULE_COMPAT_5.10.1) perl(Pod::Coverage::CountParents) perl(Pod::Eventual::Simple) perl(Pod::Find) perl(strict) perl(warnings) =====> perl-Pod-Coverage-TrustPod-0.092830-2.fc13.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Pod-Coverage-TrustPod-0.092830-2.fc13.src.rpm ====> requires for perl-Pod-Coverage-TrustPod-0.092830-2.fc13.src.rpm perl(ExtUtils::MakeMaker) perl(Pod::Coverage) perl(Pod::Eventual::Simple) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) APPROVED Both good points, Chris. Will do. New Package CVS Request ======================= Package Name: perl-Pod-Coverage-TrustPod Short Description: Allow a module's pod to contain Pod::Coverage hints Owners: iarnell Branches: F-11 F-12 InitialCC: perl-sig CVS done (by process-cvs-requests.py). built in rawhide; waiting for perl-Pod-Eventual on branches. perl-Pod-Coverage-TrustPod-0.092830-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Pod-Coverage-TrustPod-0.092830-3.fc12 perl-Pod-Coverage-TrustPod-0.092830-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Pod-Coverage-TrustPod-0.092830-3.fc11 perl-Pod-Coverage-TrustPod-0.092830-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Pod-Coverage-TrustPod'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1800 perl-Pod-Coverage-TrustPod-0.092830-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Pod-Coverage-TrustPod'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1409 perl-Pod-Coverage-TrustPod-0.092830-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. perl-Pod-Coverage-TrustPod-0.092830-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Iain, I'd like to see EPEL (4,5,6) branches for this; if you're not interested I'm happy to maintain them myself. I'm more than happy with EL-5 and 6, but there's a whole chain of deps missing in EL-4 (Mixin::Linewise -> Sub::Exporter -> Params::Util, Data::OptList, ...). Package Change Request ====================== Package Name: perl-Pod-Coverage-TrustPod New Branches: el5 el6 Owners: iarnell InitialCC: perl-sig Git done (by process-git-requests). perl-Pod-Coverage-TrustPod is built for el6. http://koji.fedoraproject.org/koji/buildinfo?buildID=205547 el5 is waiting on perl-Pod-Eventual. perl-Pod-Coverage-TrustPod-0.092830-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Pod-Coverage-TrustPod-0.092830-4.el5 perl-Pod-Coverage-TrustPod-0.092830-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. (In reply to comment #17) > I'm more than happy with EL-5 and 6, but there's a whole chain of deps missing > in EL-4 (Mixin::Linewise -> Sub::Exporter -> Params::Util, Data::OptList, ...). Once Pod::Eventual is pushed to stable, all of these dependencies will be available in EPEL-4, so can we have an EPEL-4 branch now please? Package Change Request ====================== Package Name: perl-Pod-Coverage-TrustPod New Branches: el4 Owners: iarnell InitialCC: perl-sig Git done (by process-git-requests). perl-Pod-Coverage-TrustPod-0.092830-4.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Pod-Coverage-TrustPod-0.092830-4.el4 perl-Pod-Coverage-TrustPod-0.092830-4.el4 has been pushed to the Fedora EPEL 4 stable repository. |