Bug 561389

Created attachment 399917 [details]
send non error messages to stdout

The trick is to use the correct file descriptor. Amavisd should report errors - and *only* errors - to stderr and everything else to stdout.

The patch attached does the trick for me.

Patched. I'll report back.

Patch worked. Hope this gets into the build package.

This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Please change version to 13. F13 is still using the exact same package.

Still happening in F13 and the same patch still corrects the problem.

Wouldn't be better to send this patch to upstream? They are preparing new release and your patch can be included there.

This bug can be reproduced also on F-14 and rawhide.

(In reply to comment #7)
> Wouldn't be better to send this patch to upstream? They are preparing new
> release and your patch can be included there.

Well, I'll suppose that's up to the package maintainer. But, I'll be happy to report upstream if someone can tell me where to go. I looked at the projects website [1], but can't find a bug tracker or the like.

[1] http://www.ijs.si/software/amavisd/

(In reply to comment #8)
> (In reply to comment #7)
> > Wouldn't be better to send this patch to upstream? They are preparing new
> > release and your patch can be included there.
> 
> Well, I'll suppose that's up to the package maintainer. But, I'll be happy to
> report upstream if someone can tell me where to go. I looked at the projects
> website [1], but can't find a bug tracker or the like.
> 
> [1] http://www.ijs.si/software/amavisd/

I also didn't find any email.

At least I add your patch in F-13,14,rawhide. I hope Steve won't mind.

amavisd-new-2.6.4-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/amavisd-new-2.6.4-2.fc13

amavisd-new-2.6.4-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/amavisd-new-2.6.4-2.fc14

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Wouldn't be better to send this patch to upstream? They are preparing new
> > > release and your patch can be included there.
> > 
> > Well, I'll suppose that's up to the package maintainer. But, I'll be happy to
> > report upstream if someone can tell me where to go. I looked at the projects
> > website [1], but can't find a bug tracker or the like.
> > 
> > [1] http://www.ijs.si/software/amavisd/
> 
> I also didn't find any email.
> 
> At least I add your patch in F-13,14,rawhide. I hope Steve won't mind.

Thanks a lot. I'm sure many system administrators won't mind getting less pointless mails.

amavisd-new-2.6.4-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update amavisd-new'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/amavisd-new-2.6.4-2.fc14

amavisd-new-2.6.4-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

amavisd-new-2.6.4-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

This issue seems to be still present on Fedora 13 with this patch:

# rpm -qv amavisd-new
amavisd-new-2.6.4-2.fc13.noarch

# service amavisd restart
Shutting down amavisd: Daemon [23352] terminated by SIGTERM
                                                           [  OK  ]
amavisd stopped
Starting amavisd:                                          [  OK  ]

I still receive mails from cron when sa-update restarts amavisd.

Sure, the output will show, but on stdout as expected for non-error messages. The thing is '/usr/share/spamassassin/sa-update.cron' is calling a restart on amavisd when it has installed updates and redirects stdout to /dev/null, thus the cronjob should not receive any output unless there is an error during restart.

In the previous release

# service amavisd restart > /dev/null

would have produced output (namely: 'Daemon [23352] terminated by SIGTERM') which came directly from amavisd. Amavisd is not reporting any error here, so it shouldn't be using stderr.

In the new release this is no longer the case.