Bug 561391

Summary:	Package review: openct
Product:	[Fedora] Fedora	Reporter:	Miloslav Trmač <mitr>
Component:	Package Review	Assignee:	Miloslav Trmač <mitr>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, tmraz
Target Milestone:	---	Flags:	mitr: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	openct-0.6.19-2.fc13	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-02-04 16:45:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miloslav Trmač 2010-02-03 15:45:18 UTC

(There probably was a review in Extras.)

* rpmlint:
  > openct.src:50: W: unversioned-explicit-provides pcsc-ifd-handler
  Is there a reason why this needs to be unversioned?
  > openct.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/openct-0.6.19/wiki/trac.css
  OK
  > openct.x86_64: W: service-default-enabled /etc/rc.d/init.d/openct
  Is this necessary?
  > openct.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/openct
  > openct.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/openct
  OK
  > pcsc-lite-openct.x86_64: W: no-documentation
  Probably OK

* Consider shipping NEWS

* https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

* http://fedoraproject.org/wiki/Packaging/SysVInitScript says %{_initrddir} is deprecated and %{_initddir} should be used

* "Description:" is mandatory in the LSB header of openct.init

Comment 1 Tomas Mraz 2010-02-03 20:03:43 UTC

(In reply to comment #0)
> (There probably was a review in Extras.)
> 
> * rpmlint:
>   > openct.src:50: W: unversioned-explicit-provides pcsc-ifd-handler
>   Is there a reason why this needs to be unversioned?
No, this is a virtual provide, it was never a package.

>   > openct.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/openct-0.6.19/wiki/trac.css
>   OK
>   > openct.x86_64: W: service-default-enabled /etc/rc.d/init.d/openct
>   Is this necessary?
As this is a hardware device enablement I'd prefer it run by default. It will not harm much (except slower startup) on machines without the hw.

>   > openct.x86_64: W: missing-lsb-keyword Required-Start in
> /etc/rc.d/init.d/openct
>   > openct.x86_64: W: missing-lsb-keyword Required-Stop in
> /etc/rc.d/init.d/openct
>   OK
>   > pcsc-lite-openct.x86_64: W: no-documentation
>   Probably OK
> 
> * Consider shipping NEWS
Will do.

> *
> https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
I'll contact upstream about the udev script patches later.

> * http://fedoraproject.org/wiki/Packaging/SysVInitScript says %{_initrddir} is
> deprecated and %{_initddir} should be used
OK

> * "Description:" is mandatory in the LSB header of openct.init    
OK

Comment 2 Tomas Mraz 2010-02-03 20:54:09 UTC

Package with the changes above built in rawhide here:
http://koji.fedoraproject.org/koji/buildinfo?buildID=154340

Comment 3 Miloslav Trmač 2010-02-04 15:52:35 UTC

Thanks, approved.