Bug 561482
| Summary: | Review Request: joni - Java port of Oniguruma regexp library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mo Morsi <mmorsi> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-12 16:23:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 560170 | ||
| Bug Blocks: | 561484 | ||
|
Description
Mo Morsi
2010-02-03 18:27:54 UTC
Taking this as I maintain several ruby related packages
and oniguruma.
Some notes:
* Source tarball
- No tarball cannot be downloaded from the URL written as
SOURCE0 URL.
Also, the tarball downloaded as
$ wget -O joni-1.1.3.tar.gz "http://github.com/jruby/joni/tarball/1.1.3"
differs from the tarball in your srpm:
---------------------------------------------------------------------
120420 joni-1.1.3.tar.gz
124045 joni-1.1.3-2.fc12.src/jruby-joni-bb99ccb.tar.gz
---------------------------------------------------------------------
* Requires
- There is two "jpackage-utils" entry in Requires
* linking
---------------------------------------------------------------------
56 ln -s %{_javadir}/%{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar
---------------------------------------------------------------------
- The following line is sufficient.
---------------------------------------------------------------------
ln -s %{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar
---------------------------------------------------------------------
* Stripping binaries
- Don't strip binaries by yourself and create debuginfo rpm
correctly.
* %check
- As this tarball contains test/ directory, it is preferable that
you add %check section and execute some test program there
(if possible, I am not familiar with java)
By the way I would appreciate it if you would review my review
request (bug 565603)
(In reply to comment #1) > Taking this as I maintain several ruby related packages > and oniguruma. > > Some notes: > > * Source tarball > - No tarball cannot be downloaded from the URL written as > SOURCE0 URL. > > Also, the tarball downloaded as > $ wget -O joni-1.1.3.tar.gz "http://github.com/jruby/joni/tarball/1.1.3" > differs from the tarball in your srpm: > --------------------------------------------------------------------- > 120420 joni-1.1.3.tar.gz > 124045 joni-1.1.3-2.fc12.src/jruby-joni-bb99ccb.tar.gz > --------------------------------------------------------------------- Changed. The new url in the spec file should be the complete/final github url where the tarball is located. > > * Requires > - There is two "jpackage-utils" entry in Requires > > * linking > --------------------------------------------------------------------- > 56 ln -s %{_javadir}/%{name}-%{version}.jar > $RPM_BUILD_ROOT%{_javadir}/%{name}.jar > --------------------------------------------------------------------- > - The following line is sufficient. > --------------------------------------------------------------------- > ln -s %{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar > --------------------------------------------------------------------- > Both done. > * Stripping binaries > - Don't strip binaries by yourself and create debuginfo rpm > correctly. Removed completely as the gcj aot bits are no longer needed / used in Fedora. > > * %check > - As this tarball contains test/ directory, it is preferable that > you add %check section and execute some test program there > (if possible, I am not familiar with java) Couldn't find the 'test' build target (ant test doesn't work), so leaving be for now unless this is a huge thing. > > By the way I would appreciate it if you would review my review > request (bug 565603) Looks like I just missed it, got approval this morning. Updated and uploaded new joni rpm Spec URL: http://mo.morsi.org/files/jruby/joni.spec SRPM URL: http://mo.morsi.org/files/jruby/joni-1.1.3-3.fc12.src.rpm (In reply to comment #2) > > * %check > > - As this tarball contains test/ directory, it is preferable that > > you add %check section and execute some test program there > > (if possible, I am not familiar with java) > > Couldn't find the 'test' build target (ant test doesn't work), so leaving be > for now unless this is a huge thing. - Well, then "BuildRequires(check): ant-junit" is not needed for now? - Now rpmlint warns about: --------------------------------------------------------------------- joni.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/joni-1.1.3/test/org/joni/test/TestC.java joni.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/joni-1.1.3/test/org/joni/test/TestU.java joni.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/joni-1.1.3/test/org/joni/test/TestA.java --------------------------------------------------------------------- Please fix these rpmlint messages by dos2unix or $ sed -i -e 's|\r||' TestC.java Please fix these when importing this package into Fedora CVS. --------------------------------------------------------------------- This pacakge (joni) is APPROVED by mtasaka --------------------------------------------------------------------- (In reply to comment #3) > (In reply to comment #2) > - Well, then "BuildRequires(check): ant-junit" is not needed for > now? > > Please fix these rpmlint messages by dos2unix or > $ sed -i -e 's|\r||' TestC.java Both done. Thanks for the review / approval. Final spec and srpm uploaded here: http://mo.morsi.org/files/jruby/joni.spec http://mo.morsi.org/files/jruby/joni-1.1.3-4.fc12.src.rpm Package Change Request ====================== Package Name: joni New Branches: Owners: mmorsi Updated Description: A Java port of the Oniguruma regular expressions library. The package https://admin.fedoraproject.org/pkgdb/packages/name/joni exists, but has been orphaned and deprecated. The package has been unretired; you should take ownership of it in pkgdb. Claimed ownership of devel branch in pkgdb, and successfully pushed changes to devel via cvs. Also need F-12 and F-13 branches Package Change Request ====================== Package Name: joni New Branches: F-12, F-13 Owners: mmorsi Updated Description: A Java port of the Oniguruma regular expressions library. CVS done. Would you import your new srpm? The cvs import is done, though the 'make build' step was failing and thus I couldn't submit it to bodhi. Turned out that since the package was orphaned, it was blocked in the build system, and I had to submit a ticket to unblock it https://fedorahosted.org/rel-eng/ticket/3480 Once it's unblocked I will make build and push to updates. Closing. |