Bug 561635
| Summary: | LADSPA audacious-plugin broken | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | moony |
| Component: | audacious-plugins | Assignee: | Michael Schwendt <bugs.michael> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 12 | CC: | atkac, bugs.michael |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://jira.atheme.org/browse/AUDPLUG-161 | ||
| Whiteboard: | |||
| Fixed In Version: | 2.2-17.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 533641 | Environment: | |
| Last Closed: | 2010-02-09 05:04:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
moony
2010-02-04 03:25:39 UTC
This bug is present again in the recent 2.2 update. Where have you been when Audacious 2.2 was in updates-testing for over a month? https://admin.fedoraproject.org/updates/F12/FEDORA-2010-0028 Please tell me whether this fix would be sufficient: http://koji.fedoraproject.org/koji/taskinfo?taskID=1962578 audacious-plugins-2.2-17.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update audacious-plugins'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1508 Well, the updated audacious-plugins helped, but it didn't fix it completely. In the ~/.config/audacious/config file, under [ladspa], for some reason it had "plugins=0". Perhaps this happened somehow with the 2.2 update? But, I'm running your latest audacious-plugins now and changed it to "plugins=5" (which is how many I previously had running). Now, it works, but it required that config change, so not sure how to classify the status of the bug at this point. Thanks! (In reply to comment #2) > Where have you been when Audacious 2.2 was in updates-testing for over a month? > https://admin.fedoraproject.org/updates/F12/FEDORA-2010-0028 Busy at work! > In the ~/.config/audacious/config file, under [ladspa], for
> some reason it had "plugins=0". Perhaps this happened somehow
> with the 2.2 update?
Yes, 2.2 saved crap.
What had happened prior to the 2.2 release was that the ladspa plugin's restore() function was still commented out in the source code. Apparently because it didn't build anymore due to broken/work-in-progress changes in other parts of the same file since 2.1. So the plugin did not even try to load'n'restore from the config file. Additionally, it saved values to the config file, which were broken. plugins=0 was just one. It saved .ini file section names, which were incompatible with what the broken restore() function tried to implement.
My fix mimics the config files from 2.0.1 and older. But there is no guarantee that a future version upgrade won't be incompatible. It might be that 2.3 or a later release will switch to a more complex .ini file section naming scheme for configured ladspa plugins. For example, I could imagine how the broken/incomplete implementation in 2.2 would work if finished properly, but I don't like that solution (as it would be more work to iterate over the configured plugins and their config file sections).
audacious-plugins-2.2-17.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |