Bug 561761
| Summary: | Review Request: perl-HTML-Entities-Numbered - Conversion of numbered HTML entities | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cweyl, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | cweyl:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-HTML-Entities-Numbered-0.04-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-11 07:20:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Xavier Bachelot
2010-02-04 08:41:49 UTC
This requires: Requires: perl(Test::More) >= 0.32 ...seems suspect to me :) Indeed, I'll remove it. I should now better to not trust cpanspec for this. Anything else beside of that ? New version : - Remove unwanted Requires: perl(Test::More). Spec URL: http://www.bachelot.org/fedora/SPECS/perl-HTML-Entities-Numbered.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-HTML-Entities-Numbered-0.04-2.fc12.src.rpm Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1984104 Not blockers, but:
Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given
the recent fun along those lines :)
Think about including %{?perl_default_filter} by default, even if just pro
forma. It won't hurt anything and might save some pain down the line.
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1984104
Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.
Source tarballs match upstream (sha1sum):
894094d26046006d7afd332ad3860d761ed16405 HTML-Entities-Numbered-0.04.tar.gz
894094d26046006d7afd332ad3860d761ed16405 HTML-Entities-Numbered-0.04.tar.gz.srpm
Final provides / requires are sane:
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm
perl(HTML::Entities::Numbered) = 0.04
perl-HTML-Entities-Numbered = 0.04-2.fc13
perl(HTML::Entities::Numbered::Table) = 0.01
====> requires for perl-HTML-Entities-Numbered-0.04-2.fc13.noarch.rpm
perl(base)
perl(HTML::Entities::Numbered::Table)
perl(:MODULE_COMPAT_5.10.1)
perl(strict)
perl(vars)
=====> perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm
====> requires for perl-HTML-Entities-Numbered-0.04-2.fc13.src.rpm
perl(ExtUtils::MakeMaker)
perl(Test::More) >= 0.32
APPROVED
Thanks for the review Chris. New Package CVS Request ======================= Package Name: perl-HTML-Entities-Numbered Short Description: Conversion of numbered HTML entities Owners: xavierb Branches: F-11 F-12 EL-5 InitialCC: perl-sig CVS done (by process-cvs-requests.py). Imported and building in all requested branches. (In reply to comment #5) > Not blockers, but: > > Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given > the recent fun along those lines :) > I don't get the reference, can you point me in the right direction, please ? > Think about including %{?perl_default_filter} by default, even if just pro > forma. It won't hurt anything and might save some pain down the line. > I'm about to add that to the devel branch, then probably to F-12 and F-11 too. Not sure yet if the macro is available in EPEL. perl-HTML-Entities-Numbered-0.04-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-HTML-Entities-Numbered-0.04-2.fc12 perl-HTML-Entities-Numbered-0.04-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-HTML-Entities-Numbered-0.04-2.el5 perl-HTML-Entities-Numbered-0.04-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-HTML-Entities-Numbered-0.04-2.fc11 perl-HTML-Entities-Numbered-0.04-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-HTML-Entities-Numbered'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0236 perl-HTML-Entities-Numbered-0.04-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-HTML-Entities-Numbered'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1435 perl-HTML-Entities-Numbered-0.04-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-HTML-Entities-Numbered'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1394 perl-HTML-Entities-Numbered-0.04-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. perl-HTML-Entities-Numbered-0.04-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. perl-HTML-Entities-Numbered-0.04-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |