Bug 561981
| Summary: | Review Request: php-phpunit-PHP-TokenStream - Wrapper around PHP's tokenizer extension | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christof Damian <christof> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | php-phpunit-PHP-TokenStream-0.9.1-2.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-24 08:05:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 561985 | ||
|
Description
Christof Damian
2010-02-04 21:46:28 UTC
REVIEW + rpmlint php-phpunit-PHP-TokenStream.spec: I: checking-url http://pear.phpunit.de/get/PHP_TokenStream-0.9.1.tgz (timeout 10 seconds) php-phpunit-PHP-TokenStream.src: I: checking php-phpunit-PHP-TokenStream.src: W: spelling-error Summary(en_US) PHP's -> HP's, PCP's, P HP's php-phpunit-PHP-TokenStream.src: W: spelling-error Summary(en_US) tokenizer -> tokenism, token, patronizer php-phpunit-PHP-TokenStream.src: W: spelling-error %description -l en_US PHP's -> HP's, PCP's, P HP's php-phpunit-PHP-TokenStream.src: W: spelling-error %description -l en_US tokenizer -> tokenism, token, patronizer php-phpunit-PHP-TokenStream.src: I: checking-url http://github.com/sebastianbergmann/php-token-stream (timeout 10 seconds) php-phpunit-PHP-TokenStream.src: I: checking-url http://pear.phpunit.de/get/PHP_TokenStream-0.9.1.tgz (timeout 10 seconds) php-phpunit-PHP-TokenStream.noarch: I: checking php-phpunit-PHP-TokenStream.noarch: W: spelling-error Summary(en_US) PHP's -> HP's, PCP's, P HP's php-phpunit-PHP-TokenStream.noarch: W: spelling-error Summary(en_US) tokenizer -> tokenism, token, patronizer php-phpunit-PHP-TokenStream.noarch: W: spelling-error %description -l en_US PHP's -> HP's, PCP's, P HP's php-phpunit-PHP-TokenStream.noarch: W: spelling-error %description -l en_US tokenizer -> tokenism, token, patronizer php-phpunit-PHP-TokenStream.noarch: I: checking-url http://github.com/sebastianbergmann/php-token-stream (timeout 10 seconds) php-phpunit-PHP-TokenStream.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 9 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + no license file in sources is provided + sources match the upstream sources 328c7d9e95fc9b0078b180bbb8c532d1 PHP_TokenStream-0.9.1.tgz + Source URL ok + build on F12.x86_64 + BuildRequires ok php-pear >= 1:1.8.1 php-channel(pear.phpunit.de) + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + no %define + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in koji + no test suite (Tests dir in git not provided,) + scriptlets ok - Final Requires /usr/bin/pear php-channel(pear.phpunit.de) php-common >= 5.2.0 php-tokenizer + Final Provides ok php-pear(pear.phpunit.de/PHP_TokenStream) = 0.9.1 php-phpunit-PHP-TokenStream = 0.9.1-1.fc8 + Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2002482 removing the PHP's in sumnary should be fine. ***** APPROVED ***** Thanks for the Review. I will change the summary on import. New Package CVS Request ======================= Package Name: php-phpunit-PHP-TokenStream Short Description: Wrapper around PHP's tokenizer extension Owners: cdamian Branches: F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). php-phpunit-PHP-TokenStream-0.9.1-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-phpunit-PHP-TokenStream-0.9.1-2.fc12 php-phpunit-PHP-TokenStream-0.9.1-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/php-phpunit-PHP-TokenStream-0.9.1-2.fc13 php-phpunit-PHP-TokenStream-0.9.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. php-phpunit-PHP-TokenStream-0.9.1-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: php-phpunit-PHP-TokenStream New Branches: EL-6 Owners: cdamian CVS done (by process-cvs-requests.py). |