Bug 562036
| Summary: | Initial i18n support for preupgrade | ||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Pires Soares <igor> | ||||||||||||||||||||||||||||||||||||||||||||||||
| Component: | preupgrade | Assignee: | Richard Hughes <richard> | ||||||||||||||||||||||||||||||||||||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||||||||||||||||||||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Priority: | low | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Version: | rawhide | CC: | igor, piotrdrag, rhughes, richard | ||||||||||||||||||||||||||||||||||||||||||||||||
| Target Milestone: | --- | Keywords: | i18n, Reopened | ||||||||||||||||||||||||||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||||||||||||||||||||||||||||||||
| OS: | Linux | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||||||||||||||||||||||||||||||||
| Fixed In Version: | preupgrade-1.1.5-1.fc12 | Doc Type: | Bug Fix | ||||||||||||||||||||||||||||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||||||||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Last Closed: | 2010-03-23 15:56:06 UTC | Type: | --- | ||||||||||||||||||||||||||||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||||||||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||||||||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
Description
Igor Pires Soares
2010-02-05 03:34:11 UTC
Created attachment 388945 [details]
patch for preupgrade.glade
Created attachment 388946 [details]
patch for preupgrade-cli.py
Created attachment 388947 [details]
patch for preupgrade-gtk.py
Created attachment 388948 [details]
patch for preupgrade/__init__.py
Created attachment 388949 [details]
preupgrade.desktop.in
Needed for localize .desktop messages
Created attachment 388950 [details]
po/Makevars
Created attachment 388951 [details]
po/LINGUAS
LINGUAS file listed the language tested
Created attachment 388952 [details]
po/POTFILES.in
Created attachment 388953 [details]
po/POTFILES.skip
Created attachment 388954 [details]
po/preupgrade.pot
Created attachment 388958 [details]
po/pt_BR.po
Example .PO file with some strings for testing
Could you clone the git tree, make a branch, commit your chances to your branch and then use "git format-patch master" to generate patches please? I can then easily review them and ensure they get committed. Thanks. Created attachment 389142 [details]
patch for preupgrade-cli.py
Created attachment 389143 [details]
patch for preupgrade-gtk.py
Created attachment 389145 [details]
patch for preupgrade-gtk.py
Created attachment 389146 [details]
patch for preupgrade.glade
Created attachment 389147 [details]
patch for preupgrade/__init__.py
Created attachment 389148 [details]
preupgrade.desktop.in
Created attachment 389150 [details]
po/LINGUAS
Created attachment 389151 [details]
po/Makevars
Created attachment 389152 [details]
po/POTFILES.in
Created attachment 389154 [details]
po/POTFILES.skip
Created attachment 389155 [details]
po/preupgrade.pot
Created attachment 389156 [details]
po/pt_BR.po
Richard, here are the new patches generated by git. I hope I made it right! Thanks! If it's going to use intltool, then POT file is unnecessary (it should be generated dynamically). Also Comment in .desktop should be different than Name. The .POT file I provided here is more for an example than anything else, so maintainers can easily view the extracted strings; "intltool-update -m" will regenerate preupgrade.pot accordingly. I also noticed that Comment and Name are the same in .desktop, but didn't want to change it by myself. I highly recommend developers to change it in order to provide better described information for users everywhere. commit d993d51f02fe523e558c49afc5eb30034b0229de
Author: Igor Pires Soares <igor>
Date: Tue Feb 9 11:57:58 2010 +0000
Add initial il8n support for preupgrade
Signed-off-by: Richard Hughes <richard>
:100644 100644 c9b568f... 6d0d448... M .gitignore
:100644 100644 e6a98ec... 67da4db... M Makefile
:000000 100644 0000000... 0f35c33... A po/.gitignore
:000000 100644 0000000... 7ef689e... A po/LINGUAS
:000000 100644 0000000... a9825e1... A po/Makefile
:000000 100644 0000000... 34a03a4... A po/Makevars
:000000 100644 0000000... dd13aeb... A po/POTFILES.in
:000000 100644 0000000... f105918... A po/POTFILES.skip
:000000 100644 0000000... 2652b74... A po/pt_BR.po
:100755 100755 671388c... 1b0d85f... M preupgrade-gtk.py
:000000 100644 0000000... 6d29542... A preupgrade.desktop.in
:100644 100644 dc8af7c... 926beef... M preupgrade.glade
:100644 100644 93bc744... c333f1e... M preupgrade/__init__.py
Richard, I noticed that the preupgrade-cli.py patch wasn't included. Is there any problem with it? I think it would be good to include it too. It is already listed in POTFILES.in. Also, could you please add 'transif' FAS user to preupgrade group? It would allow us to actually submit translations. :) I'm reopening this just make sure the preupgrade-cli.py patch gets applied or preupgrade will lack CLI translations. commit 9440dc472d38e2b2239eb42ac045d68f4560316a
Author: Igor Pires Soares <igor>
Date: Tue Mar 23 15:55:37 2010 +0000
Add il8n support for preupgrade-cli. Fixes rh#562036
Signed-off-by: Richard Hughes <richard>
preupgrade-1.1.5-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/preupgrade-1.1.5-1.fc12 preupgrade-1.1.5-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |