Bug 562316
Summary: | [perl spec] PERL_INSTALL_ROOT breaks installs with latest EU::MM | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> | ||||
Component: | rpmdevtools | Assignee: | Ville Skyttä <ville.skytta> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | low | ||||||
Version: | rawhide | CC: | ville.skytta | ||||
Target Milestone: | --- | Keywords: | Reopened | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | rpmdevtools-7.8-1.fc12 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2010-03-09 03:32:25 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 557015 | ||||||
Attachments: |
|
Description
Chris Weyl
2010-02-05 22:13:05 UTC
Created attachment 389211 [details]
proposed template update
Attached patch changes PERL_INSTALL_ROOT to destdir, and also changes the chmod incantation to use the %_fixperms macro instead. (Which is unrelated, but I've been wanting to change that for a while. :) )
Applied in git, thanks, leaving as ASSIGNED until there's a package build out with these changes. http://git.fedoraproject.org/git/rpmdevtools.git/?p=rpmdevtools.git;a=commitdiff;h=c58d5bd7e0d219ecd107d7d29bf2968855a548a4 http://git.fedoraproject.org/git/rpmdevtools.git/?p=rpmdevtools.git;a=commitdiff;h=a00f5e3e80860d5d2bd8d5d05e6f2eb36298e60e For the record, I did some history digging 4+ years ago and found that DESTDIR didn't work properly until ExtUtils::MakeMaker >= 6.10_08 / Perl 5.8.1, but that's no longer an issue. It may affect EL < 4 but there's no such EPEL thing and EL >= 4 should be fine. http://thread.gmane.org/gmane.linux.redhat.fedora.perl/274/focus=276 Also, for future contributions, please commit changes to your git tree and generate patches with git format-patch instead of doing git diff, e.g. "git format-patch origin/master", and do separate changes in separate commits and patches. That makes it easier for people to apply your changes. (In reply to comment #2) > For the record, I did some history digging 4+ years ago and found that DESTDIR > didn't work properly until ExtUtils::MakeMaker >= 6.10_08 / Perl 5.8.1, but > that's no longer an issue. It may affect EL < 4 but there's no such EPEL thing > and EL >= 4 should be fine. Thanks! I was wondering what the history here was; PERL_INSTALL_ROOT usage is too widespread and consistent to just be a fluke. This makes sense. > Also, for future contributions, please commit changes to your git tree and > generate patches with git format-patch instead of doing git diff, e.g. "git > format-patch origin/master", and do separate changes in separate commits and > patches. That makes it easier for people to apply your changes. No problem. FTBFS fixed in rpmdevtools-7.7-1.fc13. Closing. rpmdevtools-7.8-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rpmdevtools-7.8-1.fc12 rpmdevtools-7.8-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rpmdevtools-7.8-1.fc11 rpmdevtools-7.8-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rpmdevtools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0003 rpmdevtools-7.8-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. rpmdevtools-7.8-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |