Bug 562351

Summary:	Review Request: perl-Data-Dumper-Concise - A convenient way to reproduce a set of Dumper options
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Iain Arnell <iarnell>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, iarnell, notting
Target Milestone:	---	Flags:	iarnell: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Data-Dumper-Concise
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-02-20 23:12:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Weyl 2010-02-06 03:42:24 UTC

Spec URL: http://fedorapeople.org/~cweyl/review/perl-Data-Dumper-Concise.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Data-Dumper-Concise-1.100-1.fc11.src.rpm

Description:
This module always exports a single function, Dumper, which can be
called with an array of values to dump those values or with no arguments
to return the Data::Dumper object it hass created.  It exists,
fundamentally, as a convenient way to reproduce a set of Dumper options
that we’ve found ourselves using across large numbers of applications.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1966081

Additional Comment:

This is a new prereq of the latest DBIx::Class.

*rt-0.10_01

Comment 1 Iain Arnell 2010-02-20 08:43:29 UTC

Looks good.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2001121

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream:
8623d8cca85c0585d629425075fb5df9  Data-Dumper-Concise-1.100.tar.gz

Final provides are sane:
perl(Data::Dumper::Concise) = 1.100
perl(Data::Dumper::Concise::Sugar)  
perl(Devel::Dwarn)  
perl-Data-Dumper-Concise = 1.100-1.fc14

Final requires are sane:
perl(:MODULE_COMPAT_5.10.1)  
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(VersionedDependencies) <= 3.0.3-1
perl >= 0:5.006
perl(Data::Dumper)  
perl(Data::Dumper::Concise)  
perl(Data::Dumper::Concise::Sugar)  
perl(Exporter)  

rpmlint picks up a valid typo in %description (hass -> has)
perl-Data-Dumper-Concise.noarch: W: spelling-error %description -l en_US hass -> sash, has, ass
perl-Data-Dumper-Concise.noarch: W: spelling-error %description -l en_US ve -> be, v, e

Fix the typo and you're good to go. APPROVED.

Comment 2 Chris Weyl 2010-02-20 20:44:38 UTC

New Package CVS Request
=======================
Package Name: perl-Data-Dumper-Concise
Short Description: A convenient way to reproduce a set of Dumper options
Owners: cweyl
Branches: F-11 F-12 devel
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2010-02-20 22:23:59 UTC

CVS done (by process-cvs-requests.py).

I added an F-13 branch since that seems to have been missed.

Comment 4 Chris Weyl 2010-02-20 23:12:01 UTC

Thanks for the review! :-)

Comment 5 Iain Arnell 2010-09-02 14:28:54 UTC

Package Change Request
======================
Package Name: perl-Data-Dumper-Concise
New Branches: el6
Owners: iarnell tremble

Comment 6 Kevin Fenzi 2010-09-02 21:27:36 UTC

Git done (by process-git-requests).