Bug 56261

Summary:	source code problems
Product:	[Retired] Red Hat Linux	Reporter:	d.binderman
Component:	gdm	Assignee:	Havoc Pennington <hp>
Status:	CLOSED RAWHIDE	QA Contact:	Aaron Brown <abrown>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.2	CC:	jirka
Target Milestone:	---
Target Release:	---
Hardware:	alpha
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2001-11-14 19:15:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description d.binderman 2001-11-14 18:48:58 UTC

From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD NetscapeOnline.co.uk  (Win98; I)

Description of problem:

In compiling gdm-2.0beta2-23, I got

1.

cc: Error: slave.c, line 437: In this statement, "LC_CTYPE" is not declared. (undeclared)
                    lang = setlocale(LC_CTYPE, "");
-------------------------------------^

which I fixed with the following patch

*** slave.c.old	Thu Oct 11 11:46:56 2001
--- slave.c	Thu Oct 11 11:47:15 2001
***************
*** 23,28 ****
--- 23,29 ----
  #include <config.h>
  #include <gnome.h>
  #include <stdio.h>
+ #include <locale.h>
  #include <stdlib.h>
  #include <ctype.h>
  #include <fcntl.h>

2. 

Then I got 

cc: Info: slave.c, line 231: In this statement, an array is being accessed outside the bounds specified for the array type. (subscrbounds)
        fcntl(pipe2[0], F_SETFD, fcntl(pipe2[2], F_GETFD, 0) | FD_CLOEXEC);
---------------------------------------------^

where 

    gint pipe1[2], pipe2[2];  

I'm not sure what the fix is for this one.



Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. compile with Compaq ccc compiler
2.
3.
	

Additional info:

Comment 1 Havoc Pennington 2001-11-14 19:15:16 UTC

Almost certainly fixed in recent gdm, e.g. the one from 7.2