Bug 562840

Summary: [PATCH] Add matches for ruby modules
Product: [Fedora] Fedora Reporter: Lubomir Rintel <lkundrak>
Component: fileAssignee: Daniel Novotny <dnovotny>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 12CC: dnovotny
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: file-5.03-13.fc12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-06 03:40:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed fix none

Description Lubomir Rintel 2010-02-08 14:55:33 UTC 
Similar to what's already done for Perl. Existing rules only match shebangs,
which is not useful in most cases. This was tested to yield no false
positives when run against every perl and python source file I could find
on my system (260 CPAN modules and 59 Python modules). Produces a couple
of false negatives for a couple of files from 30 Ruby gems I have
installed, but is still an improvement over existing rules. (Ruby is
used to construct DSLs quite often, it would be really tricky to match
those).
---
 magic/Magdir/ruby |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
Comment 1 Lubomir Rintel 2010-02-08 14:56:51 UTC 
This is essential for RPM to correctly recognize Ruby files, so that ruby(abi) dependencies can be automatically generated.

Already sent to upstream author.
Comment 2 Lubomir Rintel 2010-02-08 15:01:33 UTC 
Created attachment 389536 [details]
Proposed fix
Comment 3 Daniel Novotny 2010-02-09 16:00:23 UTC 
hello,
thanks for the magic, adding in rawhide (file-5.04-3.fc13) and F12 (file-5.03-13.fc12)
Comment 4 Fedora Update System 2010-02-09 16:02:01 UTC 
file-5.03-13.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/file-5.03-13.fc12
Comment 5 Lubomir Rintel 2010-02-09 16:13:15 UTC 
Thank you for applying the patch, Dan!

I have moved your update from stable to testing as I definitely won't need for f12 (sorry if I filled the bug against wrong release). Sorry if you really insist on pushing a stable update for this.
Comment 6 Daniel Novotny 2010-02-10 12:41:24 UTC 
OK, makes sense, it can stay in F12 Testing for several days
Comment 7 Fedora Update System 2010-02-11 14:34:39 UTC 
file-5.03-13.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update file'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1698
Comment 8 Fedora Update System 2010-03-06 03:40:17 UTC 
file-5.03-13.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.