Bug 565764
| Summary: | Review Request: sugar-measure - Measure functionality for Sugar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kedar Sovani <kedars> |
| Component: | Package Review | Assignee: | Bernie Innocenti <bernie+fedora> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bernie+fedora, dennis, fedora-package-review, jitesh.1337, lmacken, orion, sebastian, tomspur |
| Target Milestone: | --- | Flags: | bernie+fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-23 15:23:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 558617 | ||
|
Description
Kedar Sovani
2010-02-16 08:17:00 UTC
Just a few comments, I'm no sponsor anyway: - Try running rpmlint -I $(warning/error) -> $ rpmlint -I non-executable-script non-executable-script: This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. - BuildRequires should be python-devel and not just python. BuildRequires python will be added automatic then. (In reply to comment #1) > Just a few comments, I'm no sponsor anyway: sure, Thanks! > > - Try running rpmlint -I $(warning/error) > > -> $ rpmlint -I non-executable-script > non-executable-script: > This text file contains a shebang or is located in a path dedicated for > executables, but lacks the executable bits and cannot thus be executed. If > the file is meant to be an executable script, add the executable bits, > otherwise remove the shebang or move the file elsewhere. > > Yes, I meant that I believe both the type of errors above are false-positives in this case. Is there any spec-file workaround for those? > - BuildRequires should be python-devel and not just python. BuildRequires > python will be added automatic then. Hmm... Actually it doesn't really need python-devel in this case, just python is sufficient. Here is a koji scratch build. http://koji.fedoraproject.org/koji/taskinfo?taskID=1992656 Ping? What's the state here? Dennis, do you still plan to review this? Upstream has released a new version here: http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025645.html Wow this review has been stuck for over 5 months! :-( Thank you for this contribution, I've approved this review request and sponsored your membership to the packagers group. Please, request the creation of the CVS repository for your package: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure Before importing, you should probably upgrade to Measure v30. Also, I would advise requesting an F-13 branch for the convenience of current SoaS-3 users. You can find me as "bernie" on #fedora-devel if you need any assistance importing your package in CVS. Please reset the fedora-cvs flag to ? when you have added a cvs request template here. Thanks. New Package CVS Request ======================= Package Name: sugar-measure Short Description: Measure functionality for Sugar Owners: kedars Branches: F-12 F-13 InitialCC: bernie git done. Upstream is now at v31: http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025670.html removing needinfo |