Bug 566686

Summary: Review Request: perl-Olson-Abbreviations - Globally unique timezones abbreviation handling
Product: [Fedora] Fedora Reporter: Marcela Mašláňová <mmaslano>
Component: Package ReviewAssignee: Chris Weyl <cweyl>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: cweyl: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-02-23 06:50:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 566688    

Description Marcela Mašláňová 2010-02-19 12:35:50 UTC 
Spec URL: http://mmaslano.fedorapeople.org/review/perl-Olson-Abbreviations.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Olson-Abbreviations-0.02-1.fc13.src.rpm
Description: This module should help you with converting commonly used and often
ambigious olson abbreviations into TZ offset notation.
Comment 1 Chris Weyl 2010-02-19 18:25:22 UTC 
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1999991
Comment 2 Chris Weyl 2010-02-19 18:32:37 UTC 
Looks good.

perl(Test::Pod) should be br'ed to run the t/pod.t.

Think about including %{?perl_default_filter} by default, even if just pro
forma.  It won't hurt anything and might save some pain down the line.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1999991

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
1bdcb5104e9288cc01f24343824d8646eb25c947 Olson-Abbreviations-0.02.tar.gz
1bdcb5104e9288cc01f24343824d8646eb25c947 Olson-Abbreviations-0.02.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Olson-Abbreviations-0.02-1.fc13.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Olson-Abbreviations-0.02-1.fc13.noarch.rpm
perl(Olson::Abbreviations) = 0.02
perl-Olson-Abbreviations = 0.02-1.fc13
====> requires for perl-Olson-Abbreviations-0.02-1.fc13.noarch.rpm
perl(:MODULE_COMPAT_5.10.1)  
perl(Moose)  
perl(MooseX::AttributeHelpers)  
perl(MooseX::ClassAttribute)  
perl(strict)  
perl(warnings)  

=====> perl-Olson-Abbreviations-0.02-1.fc13.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Olson-Abbreviations-0.02-1.fc13.src.rpm
====> requires for perl-Olson-Abbreviations-0.02-1.fc13.src.rpm
perl(ExtUtils::MakeMaker)  
perl(Moose)  
perl(MooseX::AttributeHelpers)  
perl(MooseX::ClassAttribute)  
perl(Test::More)  

APPROVED
Comment 3 Marcela Mašláňová 2010-02-22 07:06:51 UTC 
New Package CVS Request
=======================
Package Name: perl-Olson-Abbreviations
Short Description: Globally unique timezones abbreviation handling
Owners: mmaslano
Branches: F-13
InitialCC: perl-sig
Comment 4 Jason Tibbitts 2010-02-22 21:31:00 UTC 
CVS done (by process-cvs-requests.py).