Bug 566964
| Summary: | Review Request: spooles - sparse matrix library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Manfred Spraul <manfred> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | dan, fedora-package-review, msuchy, notting, terje.rosten |
| Target Milestone: | --- | Flags: | dan:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-16 13:27:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 566972 | ||
|
Description
Manfred Spraul
2010-02-20 19:07:03 UTC
Spec URL: http://sourceforge.net/projects/calculix-rpm/files/fedora/libspooles.spec/download SRPM URL: http://sourceforge.net/projects/calculix-rpm/files/fedora/libspooles-2.2-2.fc12.src.rpm/download ldconfig was missing in %post and %postun Here are issues found during my first run on the package: - the package name must be "spooles" as is the project's and the source archive name (https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming) - the libspooles.so symlink belongs to the devel subpackage - the format of changelog entries is wrong - see https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs - when macro names are used in changelog entries, they must be prefixed with % so they are not interpreted there A good start Manfred, some updates to assist you:
- align tags
- < 80 in %desc
- drop cd ${RPM_BUILD_DIR}/%{name}-%{version}, it's not needed
- change rm -rf $RPM_BUILD_ROOT/* to rm -rf $RPM_BUILD_ROOT
- simplify %install
- move libspooles.so to -devel
- clean up changelog
spec: http://terjeros.fedorapeople.org/libspooles/libspooles.spec
patch: http://terjeros.fedorapeople.org/libspooles/libspooles.spec.patch
If you could do a koji scratch build from srpm that would be nice:
https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_builds_2
Manfred, are you still interested in getting the Calculix stuff into Fedora? I'd like to, but I did not have the time to make further steps. My only progress since February is merge of upstream changes :-( Is is possible that you leave the bug reports open until after Christmas? http://sourceforge.net/projects/calculix-rpm/files/rel-2.2/ Thanks for the response and have no worries, the review can wait. Any updates soon or is the review dead? You can mark the review as dead, unfortunately :-( I'll continue to maintain the package, but it's difficult for me to find time to update it if the upstream package is updated. Thus it's not realistic that I'll be able to maintain an official Fedora package properly. If someone else is interested in taking it over, I'd support that. Closing per #8 |