Bug 567428

*** Bug 563221 has been marked as a duplicate of this bug. ***

*** Bug 569526 has been marked as a duplicate of this bug. ***

*** Bug 516819 has been marked as a duplicate of this bug. ***

*** Bug 571259 has been marked as a duplicate of this bug. ***

*** Bug 571261 has been marked as a duplicate of this bug. ***

Created attachment 403700 [details]
First batch of updates from upstream

Honour "Extended BB credits" bit for CNAs.

Fix warning messages in qla2x00_request_irqs
        The fall-back is from MSI-X to MSI to INTa

Added support for notifying user space of a fw dump

Correct EH bus-reset handling.
        Target-level resets are unlikely to complete if done after the
        bus (LIP/OLS/NOS) has been reset.  Perform target-level resets,
        if necessary, prior to hitting the bus.

Correct use-after-free issue in terminate_rport_io callback.
        The explicit logout (LOGO) issued at the end of the callback will
        flush (via normal scsi_cmnd->done()) any outstanding commands
        (FCP2) the firmware is holding.  While iterating through the
        outstanding_cmnd array in qla2x00_abort_fcport_cmds(), locking
        and unlocking of the hardware spinlock, opens-up the driver to
        cases where the processed SRB (sp) could be used after the
        command completed from interrupt context.

Add firmware ETS burst support.
        Can be used to balance NIC/FCoE traffic distribution

Added parameter to load FW from flash for 4G/8G.

Remove unused dpc flags and unused operation based on the flags.

The RSCN processing is skipped if the event received is global and vha is not recipient.

Prevent sending mbx commands from sysfs during isp reset.
        The fix prevents application path from sending get-firmware-state mbx command
        during an isp reset

Hi Lalit,

Thanks for the update.  You can continue to add patches that apply on top of this patch until this bug moves into the 'POST" state at which point a new bugzilla will be required for further updates.

Rob

(In reply to comment #7)
Hi Rob,

In this case I would post patches to this BZ and close the other BZs that I opened for more updates.

Thanks
Lalit.

*** Bug 578444 has been marked as a duplicate of this bug. ***

Created attachment 403796 [details]
Update FW version for 4G & 8G HBAs to 5.03.02

*** Bug 578449 has been marked as a duplicate of this bug. ***

Created attachment 403797 [details]
qla2xxx: Add FCP cmd priority, ISP81XX internal loopback and flash related fixes.

Allows for per-command priority setting for FCP_CMNDs (Posted on linux-scsi)

Ensure flash operation and host reset via sg_reset are mutually exclusive (To
be posted on upstream)
        The problem occurring is a hw-race where there's an outstanding
read-flash operation
        occurring while the chip is being reset (done via an sg_reset script).
        After the chip is paused, the read-flash operation never completes and
the
        DPC thread, while trying to complete the reset, is never able to
recover,
        as the HW appears to be hung...

        The fix is to wait for outstanding flash operation prior to doing a
sg_reset -h.
        And to wait for reset to complete before any flash operations.

Add internal loopback support for ISP 81XX, this is for application support (To
be posted upstream)

Comment on attachment 403796 [details]
Update FW version for 4G & 8G HBAs to 5.03.02

For FW updates separate BZ is open
https://bugzilla.redhat.com/show_bug.cgi?id=578444

Created attachment 404373 [details]
Add ISP82XX support.

Lalit,

Are all new features included here slated for rhel6 as well?  We want to avoid feature regression when updates from rhel5.6 to rhel6.0 occur.

Rob

Created attachment 411512 [details]
qla2xxx: Add FCP cmd priority, ISP81XX internal loopback and flash related fixes.

Updated 81XX internal loopback
Added:
Cleanup FCP-command-status processing debug statements. (Will be posted upstream)
Optionally disable target reset (Will be posted upstream)

Created attachment 411514 [details]
Add ISP82XX support.

Updated 82XX support patch.

------- Comment From mknutson.com 2010-05-05 06:46 EDT-------
Qlogic, If needed can you please verify these fixes also made it into the RHEL6.0 driver? Thanks.

Except ISP82XX support we will submit the bug fixes to go into RHEL 6.0.
The fixes are already posted to upstream kernel on linux-scsi.

Created attachment 419035 [details]
qla2xxx: Add ISP 82xx support

This patch is same as the ealier one except this patch adds the qla_nx.c and qla_nx.h file in correct place (driver/scsi/qla2xxx). earlier patch was adding these files in current directory.

Created attachment 419047 [details]
Second batch of fixes from upstream

Following fixes added
Check for empty slot in request queue before posting Command type 6 request.
        For ISP82xx, the check for empty slot in request queue before posting command type 6
        request was missing. This could lead to request queue entry corruptions causing
        IO timeouts.

Remove duplicate macro QLA82XX_CRB_DEV_PART_INFO

Do not enable VP in non fabric topology.
        After topology change ISP is reset and VPs are re-enabled.
        If the topology is not fabric, VPs could falsely get enabled.

Handle outstanding mbx cmds on hung f/w scenarios.

Fix flash write failure on ISP82XX
        Driver was not unprotecting correctly, use correct bits
        to unprotect the flash on ISP 82xx.

Log proper messages on loop down and port update AEN (This is RHEL 5.x specific)
        Currently due to usage of same function qla2x00_set_loop_down for
        loop down and port update AEN same message was logged into messages file.
        Moved the debug statements out of the common function to log proper
        message for loop down and port update AEN.

Lalit,

Has your last patch set been submitted upstream yet?

Chad,

This one "Check for empty slot in request queue before posting Command type 6 request" is in pipeline for upstream subission.

Rest are already posted on upstream.

Lalit.

Not sure if this code update is explicitly dependent on the firmware update or not, but I'm marking it as such for patch tracking purposes, as the firmware update under bug 578444 was posted as part of a series with the patches for this bug.

From a technical standpoint, the firmware patch is not dependent on the patches in this bz.

Created attachment 433187 [details]
Reworked ISP82XX Support.

This patch was reworked to look more resemble the upstream code.  However, there will be some differences because there is some functionality that won't be backported to RHEL 5:

- Multiple queue support
- CPU affinity dedication
- Asynchronous logins

in kernel-2.6.18-210.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Can we get test feedback from our partners requesting this feature per comment #32 please: http://people.redhat.com/jwilson/el5  

(Not setting specific NEEDINFO because this feature has been requested by several partners and not sure who to ask.)

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Kernel panic occurred on a Red Hat Enterprise Linux 5.5 FC host with a QLogic 8G FC adapter (QLE2562) while running IO with target controller faults. With this update, kernel panic no longer occurs in the aforementioned case.

This enhancement request was evaluated by the full Red Hat Enterprise Linux 
team for inclusion in a Red Hat Enterprise Linux minor release.   As a 
result of this evaluation, Red Hat has tentatively approved inclusion of 
this feature in the next Red Hat Enterprise Linux Update minor release.   
While it is a goal to include this enhancement in the next minor release 
of Red Hat Enterprise Linux, the enhancement is not yet committed for 
inclusion in the next minor release pending the next phase of actual 
code integration and successful Red Hat and partner testing.

------- Comment From jmtt.com 2010-11-19 21:27 EDT-------
Max ran a 48-hour pounder run on elm3b55, a x3550m2 destiny, to exercise the qla2xxxx driver.  No problems were seen.

No issues seen.  Verified by QLogic.

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html