Bug 567567

Summary:	guestfish integer (xstrtol) tests fail differently on 32-bit platforms
Product:	[Community] Virtualization Tools	Reporter:	Richard W.M. Jones <rjones>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	unspecified	CC:	mbooth, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-03-12 16:24:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2010-02-23 10:01:50 UTC

Description of problem:

On Debian Guido reported the following patch was necessary to
get past the guestfish integer (xstrtol / bug 557655) tests:

> -set-memsize: memsize: integer out of range
> -set-memsize: memsize: integer out of range
> -set-memsize: memsize: integer out of range
> -set-memsize: memsize: integer out of range
> +set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
> +set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
> +set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
> +set-memsize: memsize: invalid integer parameter (xstrtol returned 1)

However this looks wrong to me.  This needs further
investigation so we can find out if it's our code or Gnulib
which is at fault (or some difference in the environment).

Version-Release number of selected component (if applicable):

guestfish 1.0.84

How reproducible:

On Debian, not on Fedora.

Additional info:

Upstream report:
https://www.redhat.com/archives/libguestfs/2010-February/msg00180.html

Comment 1 Richard W.M. Jones 2010-02-25 20:21:11 UTC

Actually, this happens on Fedora/i386 too.  I think it's
a 32/64-bit thing.

--- test.err	2010-02-25 20:16:01.000000000 +0000
+++ rhbz557655-expected.stderr	2010-02-25 19:13:55.000000000 +0000
@@ -1,7 +1,7 @@
-set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
-set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
-set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
-set-memsize: memsize: invalid integer parameter (xstrtol returned 1)
+set-memsize: memsize: integer out of range
+set-memsize: memsize: integer out of range
+set-memsize: memsize: integer out of range
+set-memsize: memsize: integer out of range
 set-memsize: memsize: invalid integer parameter (xstrtol returned 4)
 set-memsize: memsize: invalid integer parameter (xstrtol returned 2)
 set-memsize: memsize: invalid integer parameter (xstrtol returned 2)
FAIL: rhbz557655.sh

Comment 2 Richard W.M. Jones 2010-03-12 16:24:42 UTC

Fixed upstream:

http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=891aac7a0c35eb25f853c3960eadf8f1f22ca60b

Comment 3 Fedora Update System 2010-04-09 14:10:45 UTC

libguestfs-1.2.1-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libguestfs-1.2.1-1.fc13

Comment 4 Fedora Update System 2010-04-13 07:44:18 UTC

libguestfs-1.2.2-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libguestfs-1.2.2-1.fc13

Comment 5 Fedora Update System 2010-04-30 23:47:26 UTC

libguestfs-1.2.2-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.