Bug 567733
| Summary: | Review Request: marave - A Simple text editor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Thomas Janssen <thomasj> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, thomasj |
| Target Milestone: | --- | Flags: | thomasj:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | marave-0.7-3.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-03 01:56:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rex Dieter
2010-02-23 19:35:27 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2009780 $ rpmlint *.rpm noarch/*.rpm marave.src: W: spelling-error %description -l en_US ommwriter -> copywriter, songwriter, ghostwriter marave.src: W: non-standard-group Unspecified marave.src: W: invalid-url URL: http://marave.googlecode.com/ IncompleteRead(0 bytes read) marave.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 3) marave.src: W: invalid-url Source0: http://marave.googlecode.com/files/marave-0.6.tar.gz HTTP Error 404: Not Found marave.noarch: W: spelling-error %description -l en_US ommwriter -> copywriter, songwriter, ghostwriter marave.noarch: W: non-standard-group Unspecified marave.noarch: W: invalid-url URL: http://marave.googlecode.com/ IncompleteRead(0 bytes read) marave.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/marave/spelltextedit.py 0644 /usr/bin/env 2 packages and 0 specfiles checked; 1 errors, 8 warnings. Not sure what's up with the Url/Source warnings, they work ok for me Spec URL: http://rdieter.fedorapeople.org/rpms/marave/marave.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/marave/marave-0.7-1.fc12.src.rpm %changelog * Thu Feb 25 2010 Rex Dieter <rdieter> 0.7-1 - marave-0.7 XX - Package meets naming and packaging guidelines http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files says: For new packages, do not apply a vendor tag to desktop files. OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 1bb038efb7a9847697bdbf671feb7f6e marave-0.7.tar.gz NN - Package needs ExcludeArch OK - BuildRequires correct NN - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot has: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) OK - Package is code or permissible content. NN - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. NN - Headers/static libs in -devel subpackage. NN - Spec has needed ldconfig in post and postun NN - .pc files in -devel subpackage/requires pkgconfig NN - .so files in -devel subpackage. NN - -devel package Requires: %{name} = %{version}-%{release} NN - .la files are removed. OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. XX - No rpmlint output. marave.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 3) Well, yeah marave.spec: W: invalid-url Source0: http://marave.googlecode.com/files/marave-0.7.tar.gz HTTP Error 404: Not Found spectool -g gets the source. No idea what's wrong there. marave.src: W: spelling-error %description -l en_US ommwriter -> copywriter, songwriter, ghostwriter Bogus, can be ignored. marave.src: W: non-standard-group Unspecified It's missing the Group tag in spec file. marave.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/marave/editor/spelltextedit.py 0644 /usr/bin/env The file contains a shebang. Is that meant to have one? 2 packages and 1 specfiles checked; 1 errors, 10 warnings. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should function as described. OK - Should have sane scriptlets. NN - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version /usr/lib/python2.6/site-packages/marave/editor/spelltextedit.py Looks like a standalone widget, so should be kosher as-is. (It has been argued packages should be patched to use #!/usr/bin/python instead, but it's a contentious issue, and is why it's not in the python guidelines yet Otherwise, fixed up the other cosmetic items, Spec URL: http://rdieter.fedorapeople.org/rpms/marave/marave.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/marave/marave-0.7-2.fc12.src.rpm %changelog * Thu Feb 25 2010 Rex Dieter <rdieter> 0.7-2 - fix whitespace - Group: Applications/Editors (In reply to comment #4) > /usr/lib/python2.6/site-packages/marave/editor/spelltextedit.py > Looks like a standalone widget, so should be kosher as-is. > (It has been argued packages should be patched to use > #!/usr/bin/python > instead, but it's a contentious issue, and is why it's not in the python > guidelines yet Hm.. Ok. > Otherwise, fixed up the other cosmetic items, > > Spec URL: http://rdieter.fedorapeople.org/rpms/marave/marave.spec > SRPM URL: http://rdieter.fedorapeople.org/rpms/marave/marave-0.7-2.fc12.src.rpm > > %changelog > * Thu Feb 25 2010 Rex Dieter <rdieter> 0.7-2 > - fix whitespace > - Group: Applications/Editors APPROVED New Package CVS Request ======================= Package Name: marave Short Description: A simple text editor Owners: rdieter Branches: F-11 F-12 InitialCC: New Package CVS Request ======================= Package Name: marave Short Description: A simple text editor Owners: rdieter Branches: F-11 F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). marave-0.7-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/marave-0.7-3.fc13 marave-0.7-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/marave-0.7-3.fc12 marave-0.7-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/marave-0.7-3.fc11 marave-0.7-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update marave'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-3104 marave-0.7-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update marave'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-3290 marave-0.7-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update marave'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-3296 marave-0.7-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. marave-0.7-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. marave-0.7-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |