Bug 567902

Summary:	system-config-printer shows error when viewing empty class
Product:	[Fedora] Fedora	Reporter:	Aaron Faanes <dafrito>
Component:	system-config-printer	Assignee:	Tim Waugh <twaugh>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	12	CC:	jpopelka, twaugh
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	system-config-printer-1.1.18-2.fc11	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	569488 (view as bug list)		Environment:
Last Closed:	2010-03-20 03:40:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	569488

Description Aaron Faanes 2010-02-24 09:20:12 UTC

Description of problem:

A 'server-error-internal-error' is shown when attempting to view the properties of an empty printer class.

Version-Release number of selected component (if applicable):

[dafrito@fritocomp etc]$ yum list installed '*cups*'
bluez-cups.x86_64 4.58-1.fc12 @updates 
cups.x86_64 1:1.4.2-25.fc12 @updates-testing
cups-libs.i686 1:1.4.2-25.fc12 @updates-testing
cups-libs.x86_64 1:1.4.2-25.fc12 @updates-testing
cups-pk-helper.x86_64 0.0.4-12.fc12 @updates-testing
gutenprint-cups.x86_64 5.2.5-2.fc12 @updates-testing
libgnomecups.x86_64 0.2.3-7.fc12 @fedora

How reproducible:

Every time.

Steps to Reproduce:
0. Add or install a new printer, if necessary.
1. Create a new class. Default fields are suitable. Add one printer to this class.

At this point, Properties for the class may be viewed and edited as expected.

2. Delete the printer that is a member of the created class. I did this via Printer > Delete on the Printer configuration page.
3. View Properties for the now empty class. 
  
Actual results:

CUPS Server Error is shown, with the following text:
There was an error during the CUPS operation: 'server-error-internal-error'.

After this message, the properties may be edited as before.

Expected results:

Either:
a.) No error should be shown when viewing properties, or
b.) The class should be implicitly removed when the last printer is deleted

Additional info:

/var/log/cups/error_log and /var/log/cups/access_log don't report anything when the error occurs, though I'll be happy to attach them on request.

Comment 1 Jiri Popelka 2010-02-24 13:51:05 UTC

This is system-config-printer bug.
CUPS web interface and /var/log/cups/error_log don't show any such problem.

with PYCUPS_DEBUG defined s-c-printer shows this message:
set_ipp_error: 1280, server-error-internal-error

Comment 2 Tim Waugh 2010-02-24 15:18:55 UTC

This is actually coming from Connection_getPPD(). I'll add some debugging output to that function at the entry and exit points, not sure why they were missing.

The question is why cupsGetPPD2() is failing to retrieve a PPD for a class name.  The documentation says that is meant to work.  I think this might be a CUPS issue after all but it needs further investigation to be sure.

Comment 4 Tim Waugh 2010-02-26 10:53:02 UTC

Seems to be intentional that we get IPP_INTERNAL_ERROR when fetching the PPD for an empty class.

Fixed upstream.

Comment 5 Fedora Update System 2010-03-10 10:53:24 UTC

system-config-printer-1.1.18-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/system-config-printer-1.1.18-1.fc11

Comment 6 Fedora Update System 2010-03-10 11:54:08 UTC

system-config-printer-1.1.18-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/system-config-printer-1.1.18-1.fc12

Comment 7 Fedora Update System 2010-03-11 07:14:41 UTC

system-config-printer-1.1.18-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-printer-1.1.18-1.fc12

Comment 8 Fedora Update System 2010-03-11 07:16:33 UTC

system-config-printer-1.1.18-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-printer-1.1.18-1.fc11

Comment 9 Fedora Update System 2010-03-16 00:38:31 UTC

system-config-printer-1.1.18-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-printer-1.1.18-1.fc11

Comment 10 Fedora Update System 2010-03-16 00:52:37 UTC

system-config-printer-1.1.18-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-printer-1.1.18-1.fc12

Comment 11 Fedora Update System 2010-03-18 03:14:54 UTC

system-config-printer-1.1.18-2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-printer-1.1.18-2.fc12

Comment 12 Fedora Update System 2010-03-18 03:29:05 UTC

system-config-printer-1.1.18-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-printer-1.1.18-2.fc11

Comment 13 Fedora Update System 2010-03-20 03:39:15 UTC

system-config-printer-1.1.18-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2010-03-23 02:11:23 UTC

system-config-printer-1.1.18-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.