Bug 568052
| Summary: | Review Request: normaliz - A tool for mathematical computations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mark Chappell <tremble> |
| Component: | Package Review | Assignee: | Terje Røsten <terje.rosten> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rdieter, terje.rosten, tremble |
| Target Milestone: | --- | Flags: | terje.rosten:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-02 14:53:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mark Chappell
2010-02-24 17:10:47 UTC
Seems mostly ok, could you add a reference to the PDF documentation in description and move the examples to a subdir in doc? You are mixing $RPM_FOO and %{foo} style macros, use
%{optflags} and %{buildroot}
or $RPM_OPT_FLAGS and $RPM_BUILD_ROOT
(same issue in 4ti2, btw)
(In reply to comment #1) > Seems mostly ok, could you add a reference to the PDF documentation in > description How would you recommend referencing it? SRPM URL: http://tremble.fedorapeople.org/packages/normaliz-2.2-2.fc12.src.rpm * examples moved into example subdirectory * switched from $RPM_BUILD_ROOT to %{buildroot} * description now includes a reference to Normaliz2.2Documentation.pdf This does however now result in an rpmlint warning normaliz.x86_64: W: macro-in-%description %{docdir} ok rpmlint ok naming ok spec ok license: GPLv3+ ok lang ok sha1sum on src 9313971e8b3ca30935727cd2f23a073654d7c4b4 Normaliz2.2Linux64.zip 9313971e8b3ca30935727cd2f23a073654d7c4b4 Normaliz2.2Linux64.zip.1 ok koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2013794 ok dirs ok perms Some small issues fixed and this will get approved: - in %install swap the two first lines: pushd source rm -rf %{buildroot} -> rm -rf %{buildroot} pushd source - change last paragraph in desc to e.g. Documentation and examples can be found in %{_docdir}/%{name}-%{version}, in particular you may find Normaliz%{version}Documentation.pdf useful. An example configuration file normaliz.cfg is also included. - consider to use dos2unix -k ... or other means to preserve timestamps on *.in and *.out files. - I don't like the spaces in Computing the integral closure of an affine semigroup.pdf, but that's might be my problem. Updated SRPM: http://tremble.fedorapeople.org/packages/normaliz-2.2-3.fc12.src.rpm - in %install swap the two first lines: Done - change last paragraph in desc: Done - consider to use dos2unix -k ... or other means to preserve timestamps Time stamps being preserved by touch - I don't like the spaces in Neither do I, replace with _s Ok, this is good, now we are at the pedantic level, start all changelog lines with lower or upper case letters, fix this during importing. The package normaliz is APPROVED. New Package CVS Request ======================= Package Name: normaliz Short Description: A tool for mathematical computations Owners: tremble Branches: F-12 F-13 EL-5 CVS done (by process-cvs-requests.py). |