Bug 568638
| Summary: | Review Request: smx - httpd server macro language | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | erik aronesty <erik> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | fedora-package-review, j, notting, opensource | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-07-03 21:39:34 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 201449 | ||||||
| Attachments: |
|
||||||
|
Description
erik aronesty
2010-02-26 08:14:39 UTC
This is probably wrong:
strip --strip-unneeded %{buildroot}/%{_libdir}/*.so
strip --strip-unneeded %{buildroot}/%{_bindir}/smx*
The files are automatically stripped by rpm and the information is stored in
the debuginfo package. When you do this yourself, the debuginfo packages will
be useless.
You can try this to get the rpmlin errors away:
%{_prefix}/share/man/man3/%%*
The %% represents one % in SPEC files.
Any response to this commentary? It's been months. Sorry, I made both changes: 1- without the strip lines, i get "unstripped binary" errors in rpmlint, and the binary is, indeed, never stripped 2- the two percent signs helped a little (one error saved out of 90)... but I still get flooded with errors on that. the problem is that the "files" glob expansion doesn't quote percent signs. Trying to figure out what to do instead of strip, and how to get the glob to put two % signs in the rpm .... when the file path has a % sign. (In reply to comment #3) > 1- without the strip lines, i get "unstripped binary" errors in rpmlint, and > the binary is, indeed, never stripped Then there should be some errors shown by a script called find-debuginfo.sh or similiar at the end of the build. The script is responsible to strip all binaries. I'm definitely not dong something correct when it comes to debug builds. I never got a debuginfo RPM. Links to the output of rpmbuild -v -ba .... without the compilation steps for readability. abbreviated rpmbuild with -v: http://www.smxlang.org/build.abbrev (full output): http://www.smxlang.org/build.out You can see it only ever writes the rpm, srpm and devel rpm (with the header). Nothing else. It seems that the whiteboard never got cleared when you responded so this has been hidden from the review reports for months. I would just close this out because it's so old, but just in case: Are you still remotely interested in submitting this package? The last spec I see needs some work but I'm sure everything can be beaten into shape if you still want to work on it. At this point I think I'll just go ahead and close this. I'm really sorry that the process broke down here but at this point there's not much that I can do about it. If you do wish to submit this in the future, please feel free to reopen this ticket, or open a new one and make sure I'm CC'd on it. |