Bug 568692
| Summary: | Search started in wrong directory due to reversed true/false clauses in if() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | James <james> | ||||
| Component: | nautilus-search-tool | Assignee: | Paul W. Frields <stickster> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 12 | CC: | stickster | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | nautilus-search-tool-0.3.0-7.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-03-09 03:34:44 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Holy moley, I can't believe how long I've stared at that plugin code without seeing this. Thanks for this patch, I'll make sure it goes upstream too. Built and tested here, looks great. I'm building now for F-12 and beyond, updates on the way soon. nautilus-search-tool-0.3.0-7.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/nautilus-search-tool-0.3.0-7.fc13 nautilus-search-tool-0.3.0-6.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/nautilus-search-tool-0.3.0-6.fc12 James, if you could help me by testing any of the updates, I'd appreciate it. The F-12 package is here: http://koji.fedoraproject.org/koji/buildinfo?buildID=158894 After you update and test it, give it some karma here: https://admin.fedoraproject.org/updates/nautilus-search-tool-0.3.0-6.fc12 The sooner I get some testing the sooner I can push it out to stable. Thanks! (In reply to comment #5) > James, if you could help me by testing any of the updates, I'd appreciate it. > The F-12 package is here: Updated, it seems to work as intended for me (for legit FS targets, reverts to home directory on things like the Wastebin; but then again, these things don't show up as start-points in g-s-t anyway. Suggest removal from context menu for these later?). nautilus-search-tool-0.3.0-7.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nautilus-search-tool'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-3110 nautilus-search-tool-0.3.0-6.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nautilus-search-tool'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-3311 nautilus-search-tool-0.3.0-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. nautilus-search-tool-0.3.0-7.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 396518 [details] Patch to reverse order of true/false clauses in affected if The if() at around line 103 in nautilus-search-tool.c seems to be the wrong way around. As shipped, it supplies gnome-search-tool with no arguments if g-s-t's version is >= 2.22; surely if this is the case, we want to pass the "--path=" argument? Otherwise, g-s-t starts the search from the last directory it was given, rather than that of the context of the Nautilus menu option by which it was invoked.