Bug 568945
| Summary: | Review Request: cifs-utils - helper programs for mounting CIFS shares | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeff Layton <jlayton> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, gdeschner, notting, ssorce, steved | ||||
| Target Milestone: | --- | Flags: | ssorce:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-03-06 11:48:59 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Jeff Layton
2010-02-27 02:46:36 UTC
This may be a bit more complex than the typical new package... The cifs utilities traditionally were shipped as part of samba upstream. Upstream, we're splitting the tools out of samba and into an entirely new repo/project. We've decided to make the initial upstream release "4.0" to make it easier for distro packagers to transition from a samba-based package to this one. Fedora has always shipped these tools as part of the samba-client package. For F13, we've already split these tools out of the samba-client package and into a cifs-utils subpackage. That package is now in updates-testing and should hopefully make it into F13 by the time its released. When we're ready to approve this package, we'll probably want to coordinate its release with a samba package release. We can then have samba stop building a cifs-utils subpackage and push this package into the repo. Users should then get the new package more or less seamlessly. We'll definitely want to do this for F14, and may even want to consider doing the same for F13 as well. Flagging as needinfo for Simo and Gunther. Simo, GD... Could you review the package when you get an opportunity? rpmlint looks clear Jeff, can you explicitly list the binaries to be installed instead of /sbin/* this will help catch changes an unexpected binaries creeping in. Created attachment 397465 [details] patch to spec file For what it's worth, here's my attempt at the spec file changes mentioned in comment #5. Thanks Justin...looks good. I went ahead and did a first official release of cifs-utils upstream today too, so I've updated the package to 4.0. I also applied Justin's patch to the specfile since it looked like it addressed all of Simo's concerns. New package and specfile are here: http://fedorapeople.org/~jlayton/cifs-utils/cifs-utils-4.0-1.fc12.src.rpm http://fedorapeople.org/~jlayton/cifs-utils/cifs-utils.spec Everything looks good to me. Acking Review. New Package CVS Request ======================= Package Name: cifs-utils Short Description: Utilities for mounting and managing CIFS shares Owners: jlayton Branches: F-13 InitialCC: CVS done (by process-cvs-requests.py). Thanks, looks good. cifs-utils-4.0-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/cifs-utils-4.0-1.fc13 |