Bug 569508

Summary: system-config-language uses hardcoded icon paths
Product: [Fedora] Fedora Reporter: Hylke Bons <hylkebons>
Component: system-config-languageAssignee: Pravin Satpute <psatpute>
Status: CLOSED WORKSFORME QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 12CC: i18n-bugs, nick, psatpute
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-15 05:19:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
attachment showing the offending icon none

Description Hylke Bons 2010-03-01 16:17:57 UTC 
system-config-language uses hardcoded icon paths, because of this it doesn't pick up the user's icon theme. This happens in the window icon and the icon that is used at the top of the tool itself.

it should use the icon name "preferences-desktop-locale" and let gtk look up the correct icon.
Comment 1 Pravin Satpute 2010-03-11 10:25:51 UTC 
it is already using that

/usr/share/icons/gnome/32x32/apps/preferences-desktop-locale.png

It will nice if you can add steps to reproduce problem you facing
Comment 2 Pravin Satpute 2010-03-18 11:32:04 UTC 
Closing this as a not a bug.
Please reopen if any problem
Comment 3 Nick Richards 2011-09-12 11:46:40 UTC 
Created attachment 522680 [details]
attachment showing the offending icon

In our meego netbook theme we have customised that icon path, but that doesn't affect the flag icon shown in this screenshot.
Comment 4 Pravin Satpute 2011-09-13 05:46:28 UTC 
This icon is provided by gnome-icon-theme-3.0.0-2.fc15.noarch, 
either patch s-c-l for it or just change /usr/share/icons/gnome/32x32/apps/preferences-desktop-locale.png with your expected .png file.

It should work.
Comment 5 Nick Richards 2011-09-13 10:00:51 UTC 
Right, in F15 the capplet has changed so it only has one icon. This bug is against F12 which may be of limited interest to other people but we're still using it as we can't yet have a GTK3 dependancy. However in F12 I can tell you that the app icon isn't picked up by the capplet inside the app, it is picked up by control centre.
Comment 6 Pravin Satpute 2011-09-14 08:56:44 UTC 
I am installing F12, can you write steps to reproduce it? actual and expected results
Comment 7 Nick Richards 2011-09-14 10:57:02 UTC 
Sure. The icon to the left of 'Please select the default language' in the application should reflect the preferences-desktop-locale icon in the active icon theme. If you want a test icon theme you can use https://meego.gitorious.org/meego-netbook-ux/meego-icon-theme/
Comment 8 Nick Richards 2011-09-14 11:00:40 UTC 
Also, I believe we've now solved this problem downstream with a distro patch to remove the icon entirely, so, given that GNOME 3 has solved this entirely you may want to resolve this WORKSFORME or somesuch.
Comment 9 Pravin Satpute 2011-09-15 05:19:46 UTC 
ok i am closing this.

Thanks nick, Do reopen if any problem persist.