Bug 569757
| Summary: | cmd.c contains invalid integer range checks on 32 bit machines | ||
|---|---|---|---|
| Product: | [Community] Virtualization Tools | Reporter: | Richard W.M. Jones <rjones> |
| Component: | libguestfs | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED UPSTREAM | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | unspecified | CC: | mbooth, virt-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-12 16:24:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Fixed upstream: http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=891aac7a0c35eb25f853c3960eadf8f1f22ca60b libguestfs-1.2.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libguestfs-1.2.1-1.fc13 libguestfs-1.2.2-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libguestfs-1.2.2-1.fc13 libguestfs-1.2.2-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: cmds.c: In function 'run_set_memsize': cmds.c:1653: warning: comparison is always false due to limited range of data type cmds.c:1653: warning: comparison is always false due to limited range of data type cmds.c: In function 'run_aug_init': cmds.c:2115: warning: comparison is always false due to limited range of data type cmds.c:2115: warning: comparison is always false due to limited range of data type [and many more like that] Version-Release number of selected component (if applicable): libguestfs 1.0.85 How reproducible: Only when compiling on a 32 bit machine. Additional info: The code at issue is: long r; [...] if (r < (-(2LL<<30)) || r > ((2LL<<30)-1)) { <--