Bug 570627
| Summary: | Review Request: cppi - C preprocessor directive indenter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <kalevlember> |
| Component: | Package Review | Assignee: | Jim Meyering <meyering> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eblake, fedora-package-review, meyering, notting |
| Target Milestone: | --- | Flags: | meyering:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | cppi-1.15-1.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-27 00:59:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kalev Lember
2010-03-04 21:30:33 UTC
rpmlint passed: cppi.src: W: spelling-error Summary(en_US) preprocessor -> processor, teleprocessing, processional cppi.src: W: spelling-error Summary(en_US) indenter -> indented, ind enter, ind-enter cppi.src: W: spelling-error %description -l en_US preprocessor -> processor, teleprocessing, processional cppi.src: W: spelling-error %description -l en_US elif -> elf, lief, life 1 packages and 0 specfiles checked; 0 errors, 4 warnings. But "rpmbuild -ba cppi.spec" fails like this: + /usr/lib/rpm/find-debuginfo.sh --strict-build-id /home/j/rpmbuild/BUILD/cppi-1.14 extracting debug info from /home/j/rpmbuild/BUILDROOT/cppi-1.14-1.fc12.x86_64/usr/bin/cppi *** ERROR: No build ID note found in /home/j/rpmbuild/BUILDROOT/cppi-1.14-1.fc12.x86_64/usr/bin/cppi error: Bad exit status from /var/tmp/rpm-tmp.lqEfeN (%install) Is there a better way? This is strange. I don't get this error on my local machine and koji scratch build (F-12, so that results are comparable with your machine) also succeeds: http://koji.fedoraproject.org/koji/taskinfo?taskID=2050634 See this build log for example (F-12 x86_64): http://koji.fedoraproject.org/koji/getfile?taskID=2050636&name=build.log When gcc is used as a linker, it should pass --build-id option to ld. Perhaps you have modified gcc or binutils installed on your machine which don't support that? Good! It's my fault after all. I had confirmed that I was using F12's /usr/bin/gcc, but I had a stray x86_64-unknown-linux-gnu-gcc earlier in my path. Removing that solved the problem. Will resume on Monday. I've gone through the must and should checklists (the latter prompted me to make a new upstream release: http://lists.gnu.org/archive/html/bug-cppi/2010-03/msg00010.html) and everything looks like it's in order, so when you update your spec for 1.15, let me know and I'll take one final look and set the flag here. * Thu Mar 18 2010 Kalev Lember <kalev> - 1.15-1 - Updated to cppi 1.15 Spec URL: http://kalev.fedorapeople.org/cppi.spec SRPM URL: http://kalev.fedorapeople.org/cppi-1.15-1.fc14.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2060492 Thanks, I've confirmed that this too builds. spec diffs are trivial, as expected. ACK! Odd... I'm currently unable to set fedora‑review = + http://thread.gmane.org/gmane.linux.redhat.fedora.devel/130810/focus=130811 even though I've just changed my FAS email address to match the BZ one. Thank you for the review! New Package CVS Request ======================= Package Name: cppi Short Description: C preprocessor directive indenter Owners: kalev meyering Branches: F-11 F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). cppi-1.15-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/cppi-1.15-1.fc12 cppi-1.15-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/cppi-1.15-1.fc11 cppi-1.15-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/cppi-1.15-1.fc13 cppi-1.15-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cppi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cppi-1.15-1.fc13 cppi-1.15-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cppi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cppi-1.15-1.fc11 cppi-1.15-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cppi'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cppi-1.15-1.fc12 cppi-1.15-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. cppi-1.15-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Any reason cppi was removed from F13: http://lists.fedoraproject.org/pipermail/test/2010-April/089871.html even though it is now in F11 and F12? F-13 is in Beta freeze, and the packages that were removed were actually F-12 packages that had inherited into F-13 through F-12 updates. See Jesse Keating's mail for more explanations: http://lists.fedoraproject.org/pipermail/devel/2010-April/134347.html cppi-1.15-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |