Bug 571416

koji build for F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2035461

... and right after submitting I've found it does not compile for F13 because of Boost changes :-(

I'll try to work it out

ok, I've managed to build on F13 successfully now:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2041817

I'll post the updated spec & srpm once I'll verify that FreeOrion compiles and runs with new version (may take a while ...)

hooray, FreeOrion runs with the updated package

so here are the new files -
spec: http://kvolny.fedorapeople.org/GiGi.spec
srpm: http://kvolny.fedorapeople.org/GiGi-0.6.0-2.r803.fc12.src.rpm

Koji builds -
dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2052785
dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2052792

- Could you please use real patches and not write them into the specfile?

- There is no %doc. Could you add at least: all COPYING Readme?

(Don't know, when I have the time to review this.
Could take a while, so if someone else stepps it, no problem.)

I started working on packaging GiGi myself because my first search didn't turn up your effort.

I disagree with the reasoning behind your using 0.6.0 for the base version number, as the code from the official 0.7.0 tarball also self-identifies as 0.6.0, and r803 from the subversion repository is definitely more recent than the 0.7.0 release.

I'd suggest building the included GG-Sketch and putting it in a subpackage.

(In reply to comment #4)
> - Could you please use real patches and not write them into the specfile?

well, I don't have time to comment case by case right now, but in general, the reason was using some variables available in .spec but not for standalone patch

> - There is no %doc. Could you add at least: all COPYING Readme?

if I recall correctly, GiGi does not install these files so it'd have to be added manually ... sure, it can be included

> (Don't know, when I have the time to review this.
> Could take a while, so if someone else stepps it, no problem.)    

heh :) ... considering the state of the upstream sources, there's no rush ... I just wanted to have some usable package, no need to push it into the distro soon, just that others can find it at least somewhere

(In reply to comment #5)
> I started working on packaging GiGi myself because my first search didn't turn
> up your effort.

no problem, as stated above, I haven't too much time to spend on this, feel free to take the best of both efforts and link a new version here

> I disagree with the reasoning behind your using 0.6.0 for the base version
> number, as the code from the official 0.7.0 tarball also self-identifies as
> 0.6.0, and r803 from the subversion repository is definitely more recent than
> the 0.7.0 release.

that is true but it can cause troubles in dependencies, I think

please try to resolve the issue with upstream before using newer version number

> I'd suggest building the included GG-Sketch and putting it in a subpackage.    

feel free to do that :-)

What is the status of this package?

I would like to have this package in distro as well so I recreated the specfile + updated source:

Spec URL: http://atkac.fedorapeople.org/GiGi.spec
SRPM URL: http://atkac.fedorapeople.org/GiGi-0.6.0-0.1.20101207svn903.fc15.src.rpm

You can review it, thank you in advance.

(In reply to comment #7)
> What is the status of this package?

sorry, I drowned in RHEL6 tasks, now catching up ...

(In reply to comment #8)
> I would like to have this package in distro as well ...

I'll gladly leave the care about GiGi up to you

btw, for what purpose do you need this?

(In reply to comment #9)
> I'll gladly leave the care about GiGi up to you
> 
> btw, for what purpose do you need this?

For FreeOrion :)

How does this version compare with the 0.7.0 version available for download from the sourceforge site?  I know this package contains an SVN checkout but it seems odd that the version is behind what's available for download.

(In reply to comment #10)
> For FreeOrion :)

well, in that case you should also include the cmake modules that FreeOrion uses ;-)

--- GiGi.spec.atkac     2010-12-08 13:45:45.000000000 +0100
+++ GiGi.spec   2010-12-13 16:36:00.431559469 +0100
@@ -53,6 +53,11 @@
 
 chmod +x $RPM_BUILD_ROOT/%{_includedir}/GG/gen_signals.py
 
+# add sources shared (used) by FreeOrion
+mkdir -p %{buildroot}/%{_datadir}/cmake/Modules
+cp cmake/Config.cmake %{buildroot}/%{_datadir}/cmake/Modules
+cp cmake/Util.cmake %{buildroot}/%{_datadir}/cmake/Modules
+
 %clean
 rm -rf $RPM_BUILD_ROOT
 
@@ -65,6 +70,7 @@
 %defattr(-,root,root,-)
 %{_includedir}/*
 %{_libdir}/pkgconfig/*
+%{_datadir}/cmake/Modules/*
 
 %changelog
 * Wed Dec 08 2010 Adam Tkac <atkac redhat com> 0.6.0-0.1.20101207svn903

(In reply to comment #11)
> How does this version compare with the 0.7.0 version available for download
> from the sourceforge site?  I know this package contains an SVN checkout but it
> seems odd that the version is behind what's available for download.

the problem is that the package is advertised as a newer version number, but the authors forgot to change it within the sources so that it identifies itself as the older version ... I see two solutions, one being used right now to keep consistency with what really is in the source, and the other to patch the sources to match the version written on the download page

Wow, you can always count on your upstreams to do completely bizarre things.  Honestly I think the current solution is OK, but I'd argue that it deserves at least a comment in the spec explaining why the version is lower than what appears on the download page.

Also, the instructions for exporting from svn should be more explicit, and should provide details about checking out the exact version which is packaged (not just "trunk").  See http://fedoraproject.org/wiki/Packaging:SourceURL

Created attachment 468502 [details]
FreeOrion.spec

maybe you can find some inspiration here ... I managed to compile this version with the new GiGi (with the abovementioned patch), the game even starts (haven't tried to actually play it, though)

(In reply to comment #13)
> Wow, you can always count on your upstreams to do completely bizarre things. 

well, seems to me that it is just a matter of changing one line in
http://gigi.svn.sourceforge.net/viewvc/gigi/trunk/GG/CMakeLists.txt?revision=878&view=markup

I've reported upstream bug, let's see if it gets resolved:
https://sourceforge.net/tracker/?func=detail&aid=3137299&group_id=84040&atid=571538

(In reply to comment #12)
> (In reply to comment #10)
> > For FreeOrion :)
> 
> well, in that case you should also include the cmake modules that FreeOrion
> uses ;-)

That's weird. Can you please tell me which Fedora do you use for building? I'm building FreeOrion (from svn) on rawhide and those modules are not needed.

(In reply to comment #15)
> (In reply to comment #13)
> > Wow, you can always count on your upstreams to do completely bizarre things. 
> 
> well, seems to me that it is just a matter of changing one line in
> http://gigi.svn.sourceforge.net/viewvc/gigi/trunk/GG/CMakeLists.txt?revision=878&view=markup
> 
> I've reported upstream bug, let's see if it gets resolved:
> https://sourceforge.net/tracker/?func=detail&aid=3137299&group_id=84040&atid=571538

Thanks for it, upstream bumped version to 0.8.0.

New spec + SRPM (it incorporates changes suggested in comment #13):
http://atkac.fedorapeople.org/GiGi.spec
http://atkac.fedorapeople.org/GiGi-0.8.0-0.2.20110103svn1035.fc15.src.rpm

(In reply to comment #16)
> That's weird. Can you please tell me which Fedora do you use for building? I'm
> building FreeOrion (from svn) on rawhide and those modules are not needed.

F14 ... well, maybe those files got in as part of some boost update in between F14 and current rawhide - out of curiousity, could you take a look which package provides Config.cmake and Util.cmake?

(In reply to comment #18)
> (In reply to comment #16)
> > That's weird. Can you please tell me which Fedora do you use for building? I'm
> > building FreeOrion (from svn) on rawhide and those modules are not needed.
> 
> F14 ... well, maybe those files got in as part of some boost update in between
> F14 and current rawhide - out of curiousity, could you take a look which
> package provides Config.cmake and Util.cmake?

There are no Config.cmake or Util.cmake installed but build simple works without them. Not sure what was changed between F14 and rawhide.

(In reply to comment #19)
> There are no Config.cmake or Util.cmake installed but build simple works
> without them. Not sure what was changed between F14 and rawhide.

just for the record, we have found these files are included in FreeOrion sources fetched from svn as the whole GiGi is included as external item - the external items are missing if you fetch FreeOrion as a tarball

the files are taken from Boost, but recent Boost doesn't include a version of the code compatible with FreeOrion

Adam, I guess after including these files, you can submit a new version to move on with this - or are you working on updating the code not to need these files?

(In reply to comment #20)
> Adam, I guess after including these files, you can submit a new version to move
> on with this - or are you working on updating the code not to need these files?

This srpm should include them:
http://atkac.fedorapeople.org/GiGi-0.8.0-0.3.20110103svn1035.fc15.src.rpm
http://atkac.fedorapeople.org/GiGi.spec

Adobe Source Libraries is now packaged separately, see bug 790628.

ping, Adam, would you update the package accordingly?

or anyone else on the CC list interested in getting this finished?

(In reply to comment #23)
> ping, Adam, would you update the package accordingly?
> 
> or anyone else on the CC list interested in getting this finished?

I'm no longer interested into getting GiGi (& FreeOrion) into Fedora so feel free to finish this task if you are still interested.