Bug 571608

Description of problem:
Customer gets ISE and java traceback email with the following stacktrace when he tries to apply changes to the package/group list on existing kickstart profiles (both RHEL 4 and RHEL 5) in Satellite 5.3. This only happens for kickstart profile created before they applied RHBA-2009-1566 (spacewalk-java* and spacewalk-taskomatic later than 0.5.44-49), and they verified kickstart profiles created after that does not have this issue.

...
Exception:
javax.servlet.ServletException: Batch update returned unexpected row count from update [0]; actual row count: 2; expected: 1
  at org.apache.struts.action.RequestProcessor.processException(RequestProcessor.java:535)
...
Caused by: org.hibernate.jdbc.BatchedTooManyRowsAffectedException: Batch update returned unexpected row count from update [0]; actual row count: 2; expected: 1
  at org.hibernate.jdbc.Expectations$BasicExpectation.checkBatched(Expectations.java:71)
  at org.hibernate.jdbc.Expectations$BasicExpectation.verifyOutcome(Expectations.java:46)
  at org.hibernate.jdbc.NonBatchingBatcher.addToBatch(NonBatchingBatcher.java:24)
  at org.hibernate.persister.entity.AbstractEntityPersister.delete(AbstractEntityPersister.java:2524)
  at org.hibernate.persister.entity.AbstractEntityPersister.delete(AbstractEntityPersister.java:2701)
  at org.hibernate.action.EntityDeleteAction.execute(EntityDeleteAction.java:74)
  at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:250)
  at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:234)
  at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:146)
  at org.hibernate.event.def.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:298)
  at org.hibernate.event.def.DefaultAutoFlushEventListener.onAutoFlush(DefaultAutoFlushEventListener.java:41)
  at org.hibernate.impl.SessionImpl.autoFlushIfRequired(SessionImpl.java:969)
  at org.hibernate.impl.SessionImpl.list(SessionImpl.java:1114)
  at org.hibernate.impl.QueryImpl.list(QueryImpl.java:79)
  at com.redhat.rhn.domain.kickstart.KickstartFactory.lookupKsPackageByKsDataAndPackageName(KickstartFactory.java:1070)
  at com.redhat.rhn.frontend.action.kickstart.EditPackagesAction.transferEdits(EditPackagesAction.java:158)
  at com.redhat.rhn.frontend.action.kickstart.EditPackagesAction.save(EditPackagesAction.java:90)
  at com.redhat.rhn.frontend.action.kickstart.EditPackagesAction.execute(EditPackagesAction.java:63)
  at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
  ... 40 more

Based on db queries (such as "select kp.kickstart_id, kp.package_name_id, pn.name, kp.position from rhnKickstartPackage kp, rhnKSData kd, rhnPackageName pn where kp.kickstart_id = kd.id and kp.package_name_id = pn.id and kp.kickstart_id in (ksid1, ksid2, ksid3) order by kp.kickstart_id, pn.name;"), looks like this is due to entries with the same kickstart_id and package_name_id but different position in rhnKickstartPackage table.  This causes KickstartPackage.findByKickstartDataAndPackageName to return more than one row, which violates the composite-id on ksData and packageName in the hibernate definition for rhnKickstartPackage.

Version-Release number of selected component (if applicable):
Red Hat Network (RHN) Satellite 5.3.0

System architecture(s):
RHEL 4U8 32-bit

How reproducible:
Always.

Steps to Reproduce:
1. Have a 5.3 satellite with a kickstart profile with some packages and/or package groups in the Software section.
2. Insert a row in rhnKickstartPackage for the above profile such that it has the same kickstart_id and package_name_id as one of the existing rows, but different position.
e.g., 
insert into rhnKickstartPackage values (205, 2077, '08-MAR-10', '08-MAR-10', 39);
3. Go to Kickstart -> Profile -> Software -> Package Groups and click on Update button.

Actual results:
Internal Server Error and above stacktrace in catalina.out and traceback email.

Expected results:
Kickstart profile is updated successfully, no ISE or traceback. 

Additional info:
Already discussed with Engineering (Justin), proposed fix and workaround to be attached.