Bug 572057

Summary: ident code has ipv6 and ipv4 port parsing reversed
Product: [Fedora] Fedora Reporter: JW <ohtmvyyn>
Component: xinetdAssignee: Jan Zeleny <jzeleny>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 12CC: jzeleny
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-19 09:08:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Swap reversed IPV4 and IPV6 code fragments none

Description JW 2010-03-10 06:58:53 UTC
Created attachment 399012 [details]
Swap reversed IPV4 and IPV6 code fragments

Description of problem:
There is code in xinetd/ident.c which wrongly reverses the treatment of ipv4 vs ipv6. I have attached a patch but to find the code just search for the first AP_INET and read.

Version-Release number of selected component (if applicable):
xinetd-2.3.14-29

How reproducible:
Always

Steps to Reproduce:
1. see patch
  
Actual results:
No problem. Code seems to work ok.

Expected results:
No problem.

Additional info:
The first AF_INET and AF_INET6 should be swapped

It is a fortunately coincidence that the sin_port and sin6_port elements are always the first element and always have the same size.

Comment 1 Jan Zeleny 2010-03-19 09:08:32 UTC
For now, the bug is fixed in rawhide, I'll issue an update for F-13 later. Since this bug isn't severe, I'm not planning fixing it in F-12 branch.